Re: Fixing bugs #379 and #427

2009-08-15 Thread Patrick McCarty
On 2009-08-14, Han-Wen Nienhuys wrote: > On Thu, Aug 13, 2009 at 8:03 PM, Patrick McCarty wrote: > > > > See the attached patch for the progress I've made.  Also attached is > > an image of Mark Polesky's example from the bug tracker: > > > > http://code.google.com/p/lilypond/issues/detail?id=379#

Re: Fixing bugs #379 and #427

2009-08-14 Thread Han-Wen Nienhuys
On Thu, Aug 13, 2009 at 8:03 PM, Patrick McCarty wrote: > > Hello, > > I've decided to dive into deep waters (the slur code) and try to fix > the popular "ugly slur" bugs, #379 and #427. > > See the attached patch for the progress I've made.  Also attached is > an image of Mark Polesky's example f

Re: Fixing bugs #379 and #427

2009-08-13 Thread Patrick McCarty
On 2009-08-14, Neil Puttock wrote: > > Two issues have caught my eye (one minor, the other more serious): > > 1. After a break, I think there's too little space between key > signature alterations and a continuation (though this also applies to > ties, so it's probably a more general issue): at l

Re: Fixing bugs #379 and #427

2009-08-13 Thread Mark Polesky
Patrick McCarty wrote: > I've decided to dive into deep waters (the slur code) and try to fix > the popular "ugly slur" bugs, #379 and #427. > > See the attached patch for the progress I've made. Also attached is > an image of Mark Polesky's example from the bug tracker: > > http://code.google.

Re: Fixing bugs #379 and #427

2009-08-13 Thread Neil Puttock
2009/8/14 Neil Puttock : > Will report back once I've given the patch a whirl. This is already very impressive, as far as I can tell. I've just run `make check' and there are no important changes visible, but I imagine that's due to the fact we haven't got any tests which really exercise this is

Re: Fixing bugs #379 and #427

2009-08-13 Thread Neil Puttock
2009/8/14 Patrick McCarty : > I've decided to dive into deep waters (the slur code) and try to fix > the popular "ugly slur" bugs, #379 and #427. Hurrah! :) You've already made more progress than I have tackling this; I spent far too much time fiddling around inside Slur_engraver::stop_translati

Fixing bugs #379 and #427

2009-08-13 Thread Patrick McCarty
Hello, I've decided to dive into deep waters (the slur code) and try to fix the popular "ugly slur" bugs, #379 and #427. See the attached patch for the progress I've made. Also attached is an image of Mark Polesky's example from the bug tracker: http://code.google.com/p/lilypond/issues/detail?i