LGTM
http://codereview.appspot.com/4176056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/02/17 18:39:21, Carl wrote:
On 2011/02/17 16:17:29, nicolas.sceaux wrote:
There is also a modification of the first fret label position, but
maybe this
is
a mistake. Is the label supposed to be vertically centered with the
fret line?
or the bottom of the label should be aligned
LGTM.
Thanks,
Carl
P.S. Can you propose your patch to git-cl to the git-cl maintainers? I
think that your approach is the right one. But I don't want to have us
in the position of needing a custom git-cl.
http://codereview.appspot.com/4176056/
Le 27 févr. 2011 à 15:17, carl.d.soren...@gmail.com a écrit :
P.S. Can you propose your patch to git-cl to the git-cl maintainers? I
think that your approach is the right one. But I don't want to have us
in the position of needing a custom git-cl.
I thought git-cl was shipped in whatever
On Sun, Feb 27, 2011 at 04:04:00PM +0100, Nicolas Sceaux wrote:
Le 27 févr. 2011 à 15:17, carl.d.soren...@gmail.com a écrit :
P.S. Can you propose your patch to git-cl to the git-cl maintainers? I
think that your approach is the right one. But I don't want to have us
in the position of
I have added new tracker issue for this patch:
http://code.google.com/p/lilypond/issues/detail?id=1530
http://codereview.appspot.com/4176056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: carl.d.sorensen_gmail.com,
Message:
Hi,
Here is a patch for fret diagrams, but as I have very little knowledge
of them I may well be wrong on some points.
First, it fixes sizing issues, when the size property is overridden: the
xo signs became too big, and too far from the first
On 2011/02/17 16:17:29, nicolas.sceaux wrote:
Hi,
Here is a patch for fret diagrams, but as I have very little knowledge
of them I
may well be wrong on some points.
First, it fixes sizing issues, when the size property is overridden:
the xo
signs became too big, and too far from the
