Re: GOP-PROP 1: python formatting - probable decision

2011-06-30 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: lilypond-devel@gnu.org Sent: Wednesday, June 15, 2011 12:11 AM Subject: GOP-PROP 1: python formatting - probable decision Unless anybody has a compelling reason against it, this is the proposal which

Re: GOP-PROP 1: python formatting - probable decision

2011-06-30 Thread Graham Percival
On Thu, Jun 30, 2011 at 02:59:10PM +0100, Phil Holmes wrote: use 4 spaces per indentation level a text editor could be used to replace \t with 8 spaces Unless we have only ever used tabs to represent double indents, this isn't self consistent. That is exactly what happened. - python files

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Werner LEMBERG
We have very few (or none) patches for python files, so a large whitespace change should not break any pending patches. And even if we have: It's straightforward to change tabs to spaces even in diff files since such an operation doesn't change the number of lines. Werner

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Federico Bruni
2011/6/15 Martin Tarenskeen m.tarensk...@zonnet.nl On Wed, 15 Jun 2011, Graham Percival wrote: Mixing indentation styles is not a great idea, and in my experience of python code documentation and examples online, the 4-space indent rule from PEP-8 is almost universally followed.

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Martin Tarenskeen
On Wed, 15 Jun 2011, Federico Bruni wrote: How can I change this behaviour, so that automatically 4-space indentation is used. Can/should I change something in my .vimrc file http://stackoverflow.com/questions/234564/tab-key-4-spaces-and-auto-indent -after-curly-braces-in-vim

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Matthias Kilian
On Wed, Jun 15, 2011 at 12:11:37AM +0100, Graham Percival wrote: There should be absolutely no tab characters for indentation in any .py file in lilypond git. All such files should be converted to use spaces only. I'd go a step further and recommend (for python files) that no tabs are used at

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Graham Percival
On Wed, Jun 15, 2011 at 11:46:01AM +0200, Matthias Kilian wrote: On Wed, Jun 15, 2011 at 12:11:37AM +0100, Graham Percival wrote: There should be absolutely no tab characters for indentation in any .py file in lilypond git. All such files should be converted to use spaces only. I'd go a

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca After the initial tab-fixes (in at most 9 files), we'll use python -tt for the build process, so no mistakes will creep in. Doesn't this assume that the doc build is actually checked for errors? -- Phil Holmes

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Graham Percival
On Wed, Jun 15, 2011 at 01:49:22PM +0100, Phil Holmes wrote: - Original Message - From: Graham Percival gra...@percival-music.ca After the initial tab-fixes (in at most 9 files), we'll use python -tt for the build process, so no mistakes will creep in. Doesn't this assume that the

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Phil Holmes
- Original Message - From: Graham Percival gra...@percival-music.ca To: Phil Holmes m...@philholmes.net Cc: lilypond-devel@gnu.org Sent: Wednesday, June 15, 2011 2:02 PM Subject: Re: GOP-PROP 1: python formatting - probable decision On Wed, Jun 15, 2011 at 01:49:22PM +0100, Phil

Re: GOP-PROP 1: python formatting - probable decision

2011-06-15 Thread Graham Percival
On Wed, Jun 15, 2011 at 02:16:37PM +0100, Phil Holmes wrote: I've not waded through the make output yet, so I don't know exactly what happens during it. It's only 36,000 lines long, so barely a challenge. I do know that some of the python scripts are put into the build tree by linking to the

GOP-PROP 1: python formatting - probable decision

2011-06-14 Thread Graham Percival
Unless anybody has a compelling reason against it, this is the proposal which will be adopted on 22 June 2011: http://lilypond.org/~graham/gop/gop_1.html GOP 1 - python formatting Proposal summary let’s follow the indentation described in PEP-8. http://www.python.org/dev/peps/pep-0008/ *

Re: GOP-PROP 1: python formatting - probable decision

2011-06-14 Thread Martin Tarenskeen
On Wed, 15 Jun 2011, Graham Percival wrote: Mixing indentation styles is not a great idea, and in my experience of python code documentation and examples online, the 4-space indent rule from PEP-8 is almost universally followed. Implementation notes Not that I contribute much python code to