Pushed as 5aac8e8d8e2b1fc490354cba2cdecd204e9d5006
http://codereview.appspot.com/5083045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
James, could you put this through the ringer? It's on patch countdown
and I don't really trust my regtesting abilities all too much.
Thanks.
http://codereview.appspot.com/5083045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
David,
On Thu, Sep 22, 2011 at 10:37 AM, d...@gnu.org wrote:
James, could you put this through the ringer? It's on patch countdown
and I don't really trust my regtesting abilities all too much.
Thanks.
http://codereview.appspot.com/5083045/
No problem, I'll update the tracker to
Passes make and reg tests
http://codereview.appspot.com/5083045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
This allows defining music functions that can be used as directionless
events, a frequently made request. It may be noted that the amount of
code needed for implementing this functionality is not exactly
staggering given the current infrastructure in lexer and parser.
I haven't looked at the code itself, but a regtest is definitely missing
from the patch.
http://codereview.appspot.com/5083045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
reinhold.kainho...@gmail.com writes:
I haven't looked at the code itself, but a regtest is definitely missing
from the patch.
http://codereview.appspot.com/5083045/
Writing regtests is one of my least favorite occupations. This feature
has been requested so often that I'd appreciate
Am Wednesday, 21. September 2011, 21:26:54 schrieb David Kastrup:
reinhold.kainho...@gmail.com writes:
I haven't looked at the code itself, but a regtest is definitely missing
from the patch.
http://codereview.appspot.com/5083045/
Writing regtests is one of my least favorite
On 2011/09/21 19:40:37, reinhold_kainhofer.com wrote:
Huh? How do you verify that your feature works at all? I'm sure you
are using
some simple test file for this. So, simply take that file, add a
\header {
doctitle=some short description } and you're done.
The example David's posted
On 2011/09/21 19:44:46, Neil Puttock wrote:
On 2011/09/21 19:40:37, http://reinhold_kainhofer.com wrote:
Huh? How do you verify that your feature works at all? I'm sure you
are using
some simple test file for this. So, simply take that file, add a
\header {
doctitle=some short
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm
File scm/c++.scm (right):
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38
scm/c++.scm:38: (define-public (event? x)
I'd prefer a less vague name for this since it's going to conflict with
the stream event predicate
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm
File scm/c++.scm (right):
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38
scm/c++.scm:38: (define-public (event? x)
On 2011/09/21 21:32:30, Neil Puttock wrote:
I'd prefer a less vague name for this since it's going to
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm
File scm/c++.scm (right):
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38
scm/c++.scm:38: (define-public (event? x)
On 2011/09/21 22:14:40, dak wrote:
On 2011/09/21 21:32:30, Neil Puttock wrote:
I'd prefer a less
Ok, I have made this based off origin/master, and I moved the stuff to
using ly:event? instead of event? (not really addressing Neil's issue at
all, merely for somewhat more symmetry to ly:music?).
Untested.
http://codereview.appspot.com/5083045/
___
If this can be verified as working, it might go on the patch countdown,
barring comments that require addressing.
Note that ly:event? is not part of the public API of
define-event-function: if ly:event?'s function name changes at some
later point of time, uses of define-event-function will not
15 matches
Mail list logo
