Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-09-06 Thread dak
LGTM https://codereview.appspot.com/264960043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-09-06 Thread thomasmorley65
On 2015/09/06 10:31:16, thomasmorley651 wrote: change name to overlay After it's been pushed I'll change said LSR-snippet accordingly. For now: PATch_NEW https://codereview.appspot.com/264960043/ ___ lilypond-devel mailing list lilypond-devel@gnu.o

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-09-05 Thread David Kastrup
thomasmorle...@gmail.com writes: > On 2015/08/31 10:27:04, dak wrote: > >> Ok, I've taken a look. Markups are so undelimited in their nature > that there is >> not much of an option other than convert-ly actually knowing all > markup commands >> with their signatures. That's doable but rather on

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-09-04 Thread thomasmorley65
On 2015/08/31 10:27:04, dak wrote: Ok, I've taken a look. Markups are so undelimited in their nature that there is not much of an option other than convert-ly actually knowing all markup commands with their signatures. That's doable but rather onerous. In addition, musicxml2ly uses the

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-08-31 Thread dak
On 2015/08/30 12:08:29, dak wrote: On 2015/08/30 12:02:14, thomasmorley651 wrote: > On 2015/08/30 11:44:52, dak wrote: > > https://codereview.appspot.com/264960043/diff/1/scm/define-markup-commands.scm > > File scm/define-markup-commands.scm (right): > > > > > https://codereview.appspot.com/

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-08-30 Thread pkx166h
Passes make, make check and a full make doc PATCH_REVIEW https://codereview.appspot.com/264960043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-08-30 Thread dak
On 2015/08/30 12:02:14, thomasmorley651 wrote: On 2015/08/30 11:44:52, dak wrote: > https://codereview.appspot.com/264960043/diff/1/scm/define-markup-commands.scm > File scm/define-markup-commands.scm (right): > > https://codereview.appspot.com/264960043/diff/1/scm/define-markup-commands.scm#

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-08-30 Thread thomasmorley65
On 2015/08/30 11:44:52, dak wrote: https://codereview.appspot.com/264960043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/264960043/diff/1/scm/define-markup-commands.scm#newcode1758 scm/define-markup-commands.scm:1758: (defi

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-08-30 Thread pkx166h
Passes make, make check and a full make doc PATCH_REVIEW https://codereview.appspot.com/264960043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-08-30 Thread dak
https://codereview.appspot.com/264960043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/264960043/diff/1/scm/define-markup-commands.scm#newcode1758 scm/define-markup-commands.scm:1758: (define-markup-command (combine-list layout

Implement new markup-command combine-list (issue 264960043 by thomasmorle...@gmail.com)

2015-08-30 Thread thomasmorley65
Reviewers: , Message: Please review PATCH_NEW Description: Implement new markup-command combine-list Allows for \markup \combine-list { a list } Please review this at https://codereview.appspot.com/264960043/ Affected files (+23, -5 lines): M scm/define-markup-commands.scm Index: scm/def