Re: Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by chazwi...@gmail.com)

2017-07-18 Thread Carl . D . Sorensen
Looks generally good to me. It's not yet complete, so I don't think it's a candidate for pushing yet. But I think you've got the right stuff in and are moving forward well. Good job! https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc File lily/chord-name-engraver.cc

Re: Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by chazwi...@gmail.com)

2017-07-08 Thread pkx166h
I've created a tracker issue for this so that it gets entered into the patch cycle proper. https://sourceforge.net/p/testlilyissues/issues/5153/ Charles I also see that you have rights to update trackers, so you will also get notifications from this as it goes through the review process.

Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by chazwi...@gmail.com)

2017-07-06 Thread nine . fierce . ballads
I reviewed the C++ file. I believe others are more qualified to review the patch as a whole. https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc File lily/chord-name-engraver.cc (right):