Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-31 Thread knupero
Patchset 2 was reviewed, counted down, pushed to staging, made it to master. Then David's patchy broke because I incorrectly assumed that every clone of a lilypond repository has a local copy of the master branch. Consequently the patch was reverted in staging and master. The fix is obvious, we

Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-16 Thread Carl . D . Sorensen
LGTM. THanks for doing this! Carl https://codereview.appspot.com/564990043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-15 Thread knupero
We display BRANCH and HEAD. If we find a merge-point with master, we display that merge-point and the history from merge-point to HEAD. If not, we display up to 10 commits of history. Finding a merge-point may fail if we are in a git repository that is not a full clone of the master repository.

Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-14 Thread Werner LEMBERG
>> What I would like to see for such branches is the ID of the commit >> where the branch is rooted in master, this is, if we have >> >> o---o---o branch >> / >> o---o---o---o---o master >> 0 1 2 3 4 >> >> I want to see ID 2 in this file, marked as the

Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-14 Thread knupero
What I would like to see for such branches is the ID of the commit where the branch is rooted in master, this is, if we have o---o---o branch / o---o---o---o---o master 0 1 2 3 4 I want to see ID 2 in this file, marked as the root of `branch'. So

Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-13 Thread Werner LEMBERG
> Well, the patch first adds the name of the branch used This is quite useful. > When I test a patch in a temporary branch, only a hash with the > subject is in tree.gittxt. The information which commit was the > base on which I applied the patch is lost, and the hash of a > temporary branch

Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-13 Thread knupero
On 2019/07/12 22:36:29, Carl wrote: Why do we want 10 commits instead of just 1? I don't see the rationale for this patch. Well, the patch first adds the name of the branch used and increases the number of commits in the history. Whether or not this is helpful depends on the situation.

Re: Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-12 Thread Carl . D . Sorensen
Why do we want 10 commits instead of just 1? I don't see the rationale for this patch. https://codereview.appspot.com/564990043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Improve content of tree.gittxt (issue 564990043 by knup...@gmail.com)

2019-07-12 Thread knupero
Reviewers: , Message: Hi everybody! With the proposed patch tree.gittxt will contain the name of the current branch as well as up to 10 commits of history. Example tree:gittxt: BRANCH: IMPROVE_TREE.GITTXT HISTORY: HASH: b9a2c64a66147f3b1b4a30f27ca4d3c96a01e982 SUBJECT: Improve