Reviewers: MikeSol,
Message:
Introduce Beam_scoring_problem::quant_range, for quickly filtering out
invalid positions.
This reduces the number of scoring passes from 40k to 20k in
morgenlied.ly with #'region-size = 4.
note - i'll use this to throw out collisions which aren't colliding in
the fu
LGTM, but I can't do a regtest today :(
http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc
File lily/beam-quanting.cc (right):
http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc#newcode215
lily/beam-quanting.cc:215: }
Very cool stuff!
I won't have time to do a re
On 2011/02/04 12:08:04, MikeSol wrote:
LGTM, but I can't do a regtest today :(
Regtest comparison looks fine.
http://codereview.appspot.com/4129050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypon
On Fri, Feb 4, 2011 at 10:08 AM, wrote:
> LGTM, but I can't do a regtest today :(
>
>
> http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc
> File lily/beam-quanting.cc (right):
>
> http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc#newcode215
> lily/beam-quanting.c
On Feb 4, 2011, at 10:19 AM, Han-Wen Nienhuys wrote:
> On Fri, Feb 4, 2011 at 10:08 AM, wrote:
>> LGTM, but I can't do a regtest today :(
>>
>>
>> http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc
>> File lily/beam-quanting.cc (right):
>>
>> http://codereview.appspot.com/4129
On Feb 4, 2011, at 10:30 AM, Mike Solomon wrote:
> On Feb 4, 2011, at 10:19 AM, Han-Wen Nienhuys wrote:
>
>> On Fri, Feb 4, 2011 at 10:08 AM, wrote:
>>> LGTM, but I can't do a regtest today :(
>>>
>>>
>>> http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc
>>> File lily/beam-qu
On Fri, Feb 4, 2011 at 1:30 PM, Mike Solomon wrote:
> On Feb 4, 2011, at 10:19 AM, Han-Wen Nienhuys wrote:
>
>> On Fri, Feb 4, 2011 at 10:08 AM, wrote:
>>> LGTM, but I can't do a regtest today :(
>>>
>>>
>>> http://codereview.appspot.com/4129050/diff/1/lily/beam-quanting.cc
>>> File lily/beam-qu
On Feb 5, 2011, at 7:40 AM, Han-Wen Nienhuys wrote:
> On Fri, Feb 4, 2011 at 1:30 PM, Mike Solomon wrote:
>> On Feb 4, 2011, at 10:19 AM, Han-Wen Nienhuys wrote:
>>
>>> On Fri, Feb 4, 2011 at 10:08 AM, wrote:
LGTM, but I can't do a regtest today :(
http://codereview.apps
On Sat, Feb 5, 2011 at 1:51 PM, Mike Solomon wrote:
>>> True, although I think it's important to account for all beaming cases if
>>> possible.
>>
>> This is a performance optimization, ie. a way to run collision
>> detection without performance impact if the object does not really
>> collide, s
