Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-18 Thread Benkő Pál
> thanks.  I made the bare changes, it was quite straightforward after > all these exchanges; now comes convert-ly and the regtests. > I guess it will take much longer. first patchset uploaded to http://codereview.appspot.com/4025044/ p ___ lilypond-de

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-08 Thread Benkő Pál
>> Good idea!  I have to figure out the centering issues and how to convert >> SCM to Interval, but this is a nice way. > > robust_scm2interval thanks. I made the bare changes, it was quite straightforward after all these exchanges; now comes convert-ly and the regtests. I guess it will take much

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-07 Thread Joe Neeman
On Sat, Jan 8, 2011 at 4:13 AM, Benkő Pál wrote: > > Good idea! I have to figure out the centering issues and how to convert > SCM to Interval, but this is a nice way. > robust_scm2interval ___ lilypond-devel mailing list lilypond-devel@gnu.org http:/

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-07 Thread Benkő Pál
hi Joe, >> > need to be careful about what happens when bar-size is set. >> > Currently, your patch will break (for example) input/regression/drums.ly >> > because it ignores bar-size. >> >> well, I think extent shouldn't be computed from size >> as it loses information, but the other way round. >

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-06 Thread Joe Neeman
On Sun, Jan 2, 2011 at 6:33 PM, Benkő Pál wrote: > hi Joe, > need to be careful about what happens when bar-size is set. > > Currently, your patch will break (for example) input/regression/drums.ly > > because it ignores bar-size. > > well, I think extent shouldn't be computed from size > as it l

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-02 Thread Benkő Pál
hi Joe, >>> Comment #9 on issue 1268 by joeneeman: [PATCH] span-bar problem >>> http://code.google.com/p/lilypond/issues/detail?id=1268 >>> >>> I've tracked the problem down to Bar_line::compound_barline, >>> which tries to >>> center the bar line around the center of the staff >>> (see lines 119

Re: Issue 1268 in lilypond: [PATCH] span-bar problem

2011-01-01 Thread Benkő Pál
hi Joe, >> do you think my patch is a good start? > > Yes, but you need to be careful about what happens when bar-size is set. > Currently, your patch will break (for example) input/regression/drums.ly > because it ignores bar-size. well, I admit I haven't run regtests, but I did now and (having