Re: Issue 1650: merge multiple header specifications. (issue 6445053)

2012-07-30 Thread Graham Percival
On Mon, Jul 30, 2012 at 02:43:46PM +, d...@gnu.org wrote: > "Incorrect title (from book)" > "Correct title (from bookpart)" > and similar. That way, it is easier to see whether the results are as > expected. sure, that sounds good. - Graham ___ li

Re: Issue 1650: merge multiple header specifications. (issue 6445053)

2012-07-30 Thread reinhold . kainhofer
LGTM, seems to work correctly on all my (reg)tests. I actually like David's idea of changing the header field values to include correctness information. Still I like comments inside sample code to make the reasons for a particular block clearer. http://codereview.appspot.com/6445053/ _

Re: Issue 1650: merge multiple header specifications. (issue 6445053)

2012-07-30 Thread dak
Reviewers: Graham Percival, Message: On 2012/07/30 14:35:05, Graham Percival wrote: LGTM, and I really like the comments in the regtests. Not me who can claim credit. In a few instances they were slightly unclear, though. I did not even bother looking at them. You'll probably tear your ha

Issue 1650: merge multiple header specifications. (issue 6445053)

2012-07-30 Thread graham
LGTM, and I really like the comments in the regtests. In a few instances they were slightly unclear, though. http://codereview.appspot.com/6445053/diff/2001/input/regression/header-book-multiple.ly File input/regression/header-book-multiple.ly (right): http://codereview.appspot.com/6445053/dif