Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-25 Thread ianhulin44
Closing Rietveld issue now that Tracker Issue 2758 has been verified. Ian http://codereview.appspot.com/6458159/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-08 Thread ianhulin44
On 2012/09/08 09:13:17, dak wrote: On 2012/09/06 23:24:04, Ian Hulin (gmail) wrote: > On 2012/09/06 18:07:53, dak wrote: > > > When we go Guilev2, we don't want to search for all the backward > compatibility. > > So I'd say you use something like > > > > #if GUILEV1 > > > > for splicing in the co

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-08 Thread dak
On 2012/09/06 23:24:04, Ian Hulin (gmail) wrote: On 2012/09/06 18:07:53, dak wrote: > When we go Guilev2, we don't want to search for all the backward compatibility. > So I'd say you use something like > > #if GUILEV1 > > for splicing in the compatibility stuff, and define it as either 0 or 1

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-06 Thread ianhulin44
On 2012/09/06 18:07:53, dak wrote: On 2012/09/06 17:20:59, Ian Hulin (gmail) wrote: > On 2012/09/03 07:25:20, Patrick McCarty wrote: > > On 2012/09/03 05:39:57, dak wrote: > > > On 2012/09/03 03:41:39, Patrick McCarty wrote: > > > > LGTM > > > > > > Let's not get this merged. ly_lily_module_cons

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-06 Thread dak
On 2012/09/06 17:20:59, Ian Hulin (gmail) wrote: On 2012/09/03 07:25:20, Patrick McCarty wrote: > On 2012/09/03 05:39:57, dak wrote: > > On 2012/09/03 03:41:39, Patrick McCarty wrote: > > > LGTM > > > > Let's not get this merged. ly_lily_module_constant ("module-variable") is > > available in

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-06 Thread ianhulin44
On 2012/09/03 07:25:20, Patrick McCarty wrote: On 2012/09/03 05:39:57, dak wrote: > On 2012/09/03 03:41:39, Patrick McCarty wrote: > > LGTM > > Let's not get this merged. ly_lily_module_constant ("module-variable") is > available in _both_ Guile 1.8 as well as Guile 2.0. Thanks for mentioni

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-03 Thread pnorcks
On 2012/09/03 05:39:57, dak wrote: On 2012/09/03 03:41:39, Patrick McCarty wrote: > LGTM Let's not get this merged. ly_lily_module_constant ("module-variable") is available in _both_ Guile 1.8 as well as Guile 2.0. Thanks for mentioning this; I didn't recall the Scheme procedure being ava

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-02 Thread dak
On 2012/09/03 03:41:39, Patrick McCarty wrote: LGTM Let's not get this merged. ly_lily_module_constant ("module-variable") is available in _both_ Guile 1.8 as well as Guile 2.0. It may cause a slight cell count hit in Guile 1.8, but we don't want Guile 1 to stick around until the end of 2.17

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-02 Thread pnorcks
LGTM http://codereview.appspot.com/6458159/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-08-21 Thread graham
LGTM http://codereview.appspot.com/6458159/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-08-19 Thread ianhulin44
Reviewers: , Message: Cleaned up garbage in Subject and Description Fields. Description: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. The V2.17.0 definition of ly_module_lookup in module-scheme.cc uses two functions, scm_sym2var and scm_module_lookup_closure, which