Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-26 Thread david . nalesnik
https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely#newcode2777

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-25 Thread simon . albrecht
One typo did I spot :-) https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely#newcode2777

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-25 Thread david . nalesnik
On 2017/01/25 20:43:23, david.nalesnik wrote: diagram syntax, other improvements This is as clear as I can make this I think, so I will resist the temptation to post a follow-up patch in case reviewers would like to comment! https://codereview.appspot.com/319150043/

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
On 2017/01/24 23:32:51, t.daniels_treda.co.uk wrote: mailto:david.nales...@gmail.com wrote Tuesday, January 24, 2017 10:57 PM > Question: > > How do I get a backslash in @subsubsubheading{} ? > > The literal symbol doesn't show up, and @backslashchar{} displays > @backslashchar{} From

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
Question: How do I get a backslash in @subsubsubheading{} ? The literal symbol doesn't show up, and @backslashchar{} displays @backslashchar{} https://codereview.appspot.com/319150043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
I've posted an extensive rewrite which hopefully addresses all the concerns. I think the result is a lot more user-friendly. Note that I did not change the argument-name "offsets". My preference would be to use "displacements" here, because I think it is exactly expressive of its use. The

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
Thanks so such for the detailed review! Will post a patch update in the near future. https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right):

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread pkx166h
David, Thanks for doing this - I know how hard it is to add a large entry in the NR (and that is coming from a Native English speaker). My comments below are, I hope, constructive. Anything I can do to help you, let me know.

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-23 Thread thomasmorley65
Two thoughts, otherwise LGTM https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-23 Thread simon . albrecht
LGTM. https://codereview.appspot.com/319150043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-22 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Issue 3830: Document \offset command Please review this at https://codereview.appspot.com/319150043/ Affected files (+142, -0 lines): M Documentation/notation/changing-defaults.itely