On 2014/09/07 05:22:02, Keith wrote:
Patch set 5 will probably be fine.
My concern was that someone would be confused that adding to the list
of tags to
keep
\keepWithTag editorial { ... \tag#'editorial \tag#'score \bar'||'
}
\keepWithTag part.editorial { ... \tag#'editorial \tag#'
Patch set 5 will probably be fine.
My concern was that someone would be confused that adding to the list of tags
to keep
\keepWithTag editorial { ... \tag#'editorial \tag#'score \bar'||' }
\keepWithTag part.editorial { ... \tag#'editorial \tag#'score \bar'||' }
can reduce the things that a
https://codereview.appspot.com/137920043/diff/80001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/137920043/diff/80001/Documentation/notation/input.itely#newcode2230
Documentation/notation/input.itely:2230: will then be perfect
On 2014/09/06 18:55:42, Keith wrote:
The behavior of the old patch seemed better, in the case where someone
does
combine a \keepWithTags A.C with A and C from different groups. In
that case,
the user knows about both tag-groups and might be thinking of them as
a unified
group, and expect t
The behavior of the old patch seemed better, in the case where someone
does combine a \keepWithTags A.C with A and C from different groups. In
that case, the user knows about both tag-groups and might be thinking of
them as a unified group, and expect that command to keep music tagged
\tag#'A \ta
LGTM. Thanks David.
Trevor
https://codereview.appspot.com/137920043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly#newcode562
ly/music-functions-init.ly:562: more than one tag group defined with
@code{\\tagGroup}
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly#newcode562
ly/music-functions-init.ly:562: more than one tag group defined with
@code{\\tagGroup}
Apart from an inconsistency, marked below, LGTM.
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/137920043/diff/40001/ly/music-functions-init.ly#newcode562
ly/music-functions-init.ly:562: mor
At 10:35 on 05 Sep 2014, David Kastrup wrote:
>mark.opu...@googlemail.com writes:
>
>> https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely
>> File Documentation/notation/input.itely (left):
>>
>> https://codereview.appspot.com/137920043/diff/20001/Documentation/no
mark.opu...@googlemail.com writes:
> https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely
> File Documentation/notation/input.itely (left):
>
> https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely#oldcode2075
> Documentation/notat
https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely
File Documentation/notation/input.itely (left):
https://codereview.appspot.com/137920043/diff/20001/Documentation/notation/input.itely#oldcode2075
Documentation/notation/input.itely:2075: @funindex \appendToTa
On 2014/09/05 06:59:18, Keith wrote:
LGTM
It worked fine on (adapted) examples from the divisi staff issue and
emails.
Looking at the code, I was confused how it worked without the
\cleansed concept
of the LSR entries, until I realized un-grouped tags effectively form
their own
group, so ol
LGTM
It worked fine on (adapted) examples from the divisi staff issue and
emails. Looking at the code, I was confused how it worked without the
\cleansed concept of the LSR entries, until I realized un-grouped tags
effectively form their own group, so old uses of \keepWithTag ignore
tags in the n
14 matches
Mail list logo
