Re: Issue 4419: Engraving ends too early (issue 252970043 by d...@gnu.org)

2015-07-10 Thread dak
Reviewers: Dan Eble, Message: On 2015/07/10 02:56:43, Dan Eble wrote: I haven't absorbed enough of the background knowledge on iteration to say credibly that this looks good, although the C++ looks fine. Because this is a second try at fixing a problem, perhaps a regression test should

Issue 4419: Engraving ends too early (issue 252970043 by d...@gnu.org)

2015-07-09 Thread nine . fierce . ballads
I haven't absorbed enough of the background knowledge on iteration to say credibly that this looks good, although the C++ looks fine. Because this is a second try at fixing a problem, perhaps a regression test should be written or expanded to cover the case that the first try did not.

Re: Issue 4419: Engraving ends too early (issue 252970043 by d...@gnu.org)

2015-07-09 Thread nine . fierce . ballads
Also, thank you. https://codereview.appspot.com/252970043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel