LGTM now, thanks!
https://codereview.appspot.com/579270051/
On 2020/02/01 18:55:50, lemzwerg wrote:
> > In `-std=c++11`, most POSIX functions/definitions cannot
> > be used.
> > Also `putenv ()` and `chroot ()` cannot be used.
>
> What about using
>
> AC_USE_SYSTEM_EXTENSIONS
>
> instead (in `configure.in`) to activate many POSIX functionality?
done.
> In `-std=c++11`, most POSIX functions/definitions cannot
> be used.
> Also `putenv ()` and `chroot ()` cannot be used.
What about using
AC_USE_SYSTEM_EXTENSIONS
instead (in `configure.in`) to activate many POSIX functionality?
https://codereview.appspot.com/579270051/
On 2020/02/01 12:06:02, Dan Eble wrote:
> I see two uses of strdup.
> The one in piano-pedal-engraver looks like it could be eliminated by
using
> std::string instead of a C string.
See https://codereview.appspot.com/557270049/ .
It seems worthwhile independent of the gnu++11 question.
https://co
On 2020/02/01 15:04:41, trueroad wrote:
> In `-std=c++11`, most POSIX functions/definitions cannot be used.
> Also `putenv ()` and `chroot ()` cannot be used.
But is it the case that the implementations of those functions requires
GNU C++ extensions, or is it the case that their header files are n
In `-std=c++11`, most POSIX functions/definitions cannot be used.
Also `putenv ()` and `chroot ()` cannot be used.
These missing raises error in compiling LilyPond.
We can define `M_PI` if there is no `M_PI` definition.
We can implement `strdup ()` alternative by using only strict C++11
standard f
On 2020/02/01 12:06:02, Dan Eble wrote:
> I see two uses of strdup.
> The one in piano-pedal-engraver looks like it could be eliminated by
using
> std::string instead of a C string.
> The one in relocate.cc looks like it could be replaced by
strlen+malloc+strncpy.
I can work on a patch for these.
On 2020/02/01 08:04:36, trueroad wrote:
> Even if we define `M_PI`, an error raises since there is no `strdup
()`.
I see two uses of strdup.
The one in piano-pedal-engraver looks like it could be eliminated by
using std::string instead of a C string.
The one in relocate.cc looks like it could be r
Preliminary reaction: I don't like it. This might be a case of missing
includes which are implicitly included in one case and not in another.
https://codereview.appspot.com/579270051/
Reviewers: lemzwerg,
Message:
On 2020/02/01 07:10:17, lemzwerg wrote:
> Mhmm, wouldn't it be better to simply define `M_PI` if it is not
defined? GNU
> options might not be available with other compilers...
`-std=c++11` cannot use not only `M_PI` but also POSIX functions such as
`strdup ()`.
Eve
Mhmm, wouldn't it be better to simply define `M_PI` if it is not
defined? GNU options might not be available with other compilers...
https://codereview.appspot.com/579270051/
11 matches
Mail list logo
