Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-28 Thread adam . spiers
Pushed to staging as f955789f..0fa48c98 http://codereview.appspot.com/5343050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-27 Thread Adam Spiers
On Sun, Nov 27, 2011 at 1:21 AM, carl.d.soren...@gmail.com wrote: As far as I can see, this patch is approved for pushing, but hasn't been pushed yet. Are you going to push it, Adam, or should I push the one that I have? I will do it now. I guess I have to rebase each branch off staging and

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-27 Thread David Kastrup
Adam Spiers adam.spi...@gmail.com writes: On Sun, Nov 27, 2011 at 1:21 AM, carl.d.soren...@gmail.com wrote: As far as I can see, this patch is approved for pushing, but hasn't been pushed yet. Are you going to push it, Adam, or should I push the one that I have? I will do it now. I guess

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-26 Thread Carl . D . Sorensen
As far as I can see, this patch is approved for pushing, but hasn't been pushed yet. Are you going to push it, Adam, or should I push the one that I have? Thanks, Carl http://codereview.appspot.com/5343050/ ___ lilypond-devel mailing list

Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-07 Thread Carl . D . Sorensen
I am not in favor of the tab-to-space change in scm/chord-ignatzek-names.scm, since we don't yet have agreement on removing tabs from .scm files, AFAICS. However, if nobody else is worried about it, I won't complain. I'd prefer to have the tabs gone. And if we can do it through the backdoor,

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-07 Thread pkx166h
Passes make but two reg test diffs - see http://code.google.com/p/lilypond/issues/detail?id=1503#c32 James http://codereview.appspot.com/5343050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-07 Thread Graham Percival
On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote: I am not in favor of the tab-to-space change in scm/chord-ignatzek-names.scm, since we don't yet have agreement on removing tabs from .scm files, AFAICS. True, but I assume that other parts of the patch set depend on

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-07 Thread Adam Spiers
On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival gra...@percival-music.ca wrote: On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote: I am not in favor of the tab-to-space change in scm/chord-ignatzek-names.scm, since we don't yet have agreement on removing tabs from .scm

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-07 Thread David Kastrup
Adam Spiers adam.spi...@gmail.com writes: On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival gra...@percival-music.ca wrote: On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote: I am not in favor of the tab-to-space change in scm/chord-ignatzek-names.scm, since we don't

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-07 Thread Adam Spiers
On Mon, Nov 7, 2011 at 10:11 PM, David Kastrup d...@gnu.org wrote: In this case, the damage is already done, so there seems little point in investing the effort for trying to get back again. Especially considering my first patch submission did *not* have gratuitous whitespace changes, and I

Re: Issues 1503 and 1572 - improved jazz chord support. (issue 5343050)

2011-11-07 Thread Carl Sorensen
On 11/7/11 2:48 PM, Adam Spiers adam.spi...@gmail.com wrote: On Mon, Nov 7, 2011 at 9:13 PM, Graham Percival gra...@percival-music.ca wrote: On Mon, Nov 07, 2011 at 08:13:46PM +, carl.d.soren...@gmail.com wrote: I am not in favor of the tab-to-space change in scm/chord-ignatzek-names.scm,