Re: Let repeatTie work inside of event-chord (issue 335910043 by thomasmorle...@gmail.com)

2017-10-24 Thread dak
On 2017/10/24 08:34:13, thomasmorley651 wrote: I tried to make both engravers as equal as I could, to make it easy for a follow up to create a common base class for both. My own naive attempts to introduce something like 'semi-tie-event' failed, though. This looks really similar. I worked

Re: Let repeatTie work inside of event-chord (issue 335910043 by thomasmorle...@gmail.com)

2017-10-24 Thread thomasmorley65
I tried to make both engravers as equal as I could, to make it easy for a follow up to create a common base class for both. My own naive attempts to introduce something like 'semi-tie-event' failed, though. https://codereview.appspot.com/335910043/

Re: Let repeatTie work inside of event-chord (issue 335910043 by thomasmorle...@gmail.com)

2017-10-22 Thread thomasmorley65
On 2017/10/22 20:01:03, dak wrote: On 2017/10/22 19:26:12, benko.pal wrote: > if it's really the same, can't it be used without copying? or if separate > classes are absolutely needed, can't the common part be gathered in a common > base class? You mean, like with Slur/PhrasingSlur?

Re: Let repeatTie work inside of event-chord (issue 335910043 by thomasmorle...@gmail.com)

2017-10-22 Thread dak
On 2017/10/22 19:26:12, benko.pal wrote: if it's really the same, can't it be used without copying? or if separate classes are absolutely needed, can't the common part be gathered in a common base class? You mean, like with Slur/PhrasingSlur? Well, for one thing, then someone needs to

Re: Let repeatTie work inside of event-chord (issue 335910043 by thomasmorle...@gmail.com)

2017-10-22 Thread benko . pal
if it's really the same, can't it be used without copying? or if separate classes are absolutely needed, can't the common part be gathered in a common base class? https://codereview.appspot.com/335910043/ ___ lilypond-devel mailing list

Let repeatTie work inside of event-chord (issue 335910043 by thomasmorle...@gmail.com)

2017-10-21 Thread thomasmorley65
Reviewers: , Message: please review Description: Let repeatTie work inside of event-chord The previous coding of repeat-tie-engraver.cc is replaced by the renamed coding of the laissez-vibrer-engraver. Please review this at https://codereview.appspot.com/335910043/ Affected files (+37, -21