Reviewers: carl.d.sorensen_gmail.com, Graham Percival, Neil Puttock,
http://codereview.appspot.com/1543042/diff/17001/18007
File scripts/lilypond-book.py (right):
http://codereview.appspot.com/1543042/diff/17001/18007#newcode207
scripts/lilypond-book.py:207: group = OptionGroup (p, Options
On Fri, Jun 11, 2010 at 12:59 PM, reinhold.kainho...@gmail.com wrote:
Please review this at http://codereview.appspot.com/1543042/show
I think you pushed it to master accidentally. But I'm checking to see
if it compiles right now; if it works, let's just leave it there
instead of reverting,
Am Freitag, 11. Juni 2010, 14:59:23 schrieb Graham Percival:
On Fri, Jun 11, 2010 at 12:59 PM, reinhold.kainho...@gmail.com wrote:
Please review this at http://codereview.appspot.com/1543042/show
I think you pushed it to master accidentally.
No, not accidentally. You said LGTM and Neil
On Fri, Jun 11, 2010 at 2:21 PM, Reinhold Kainhofer
reinh...@kainhofer.com wrote:
Am Freitag, 11. Juni 2010, 14:59:23 schrieb Graham Percival:
On Fri, Jun 11, 2010 at 12:59 PM, reinhold.kainho...@gmail.com wrote:
Please review this at http://codereview.appspot.com/1543042/show
I think you
Hi Reinhold,
LGTM.
Images inside info are all present and correct (using emacs).
Cheers,
Neil
http://codereview.appspot.com/1543042/diff/17001/18007
File scripts/lilypond-book.py (right):
http://codereview.appspot.com/1543042/diff/17001/18007#newcode207
scripts/lilypond-book.py:207: group =
Looks good to me; it compiles cleanly from scratch, and all doc formats
look normal.
(I couldn't check images inside info, since I don't know how to display
those)
http://codereview.appspot.com/1543042/show
___
lilypond-devel mailing list
Looks nicely done to me. It was a big job!
Thanks,
Carl
http://codereview.appspot.com/1543042/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
