Re: Make user-generated tab-clefs possible (issue 13612043)

2013-09-08 Thread dak
https://codereview.appspot.com/13612043/diff/6001/scm/parser-clef.scm File scm/parser-clef.scm (right): https://codereview.appspot.com/13612043/diff/6001/scm/parser-clef.scm#newcode23 scm/parser-clef.scm:23: (define-session-public supported-clefs Huh. I though we had that already.

Re: Make user-generated tab-clefs possible (issue 13612043)

2013-09-07 Thread thomasmorley65
Hi, please review. https://codereview.appspot.com/13612043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Make user-generated tab-clefs possible (issue 13612043)

2013-09-07 Thread ianhulin44
Nit-pick re comment wording. is valuated by isn't really clear, is it a 'sounds-like' error for 'evaluated' or 'validated', or the suggestion I've made below. Cheers, Ian https://codereview.appspot.com/13612043/diff/6001/scm/tablature.scm File scm/tablature.scm (right):