2011/5/25 Graham Percival gra...@percival-music.ca:
On Wed, May 25, 2011 at 05:02:42PM +0100, Phil Holmes wrote:
Could you push, please?
Sure, please do
git format-origin patch
I'd better say 'git format-patch origin'.
(I think -- it's been a while! actual command is in the CG)
and send
LGTM
http://codereview.appspot.com/4515042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
- Original Message -
From: percival.music...@gmail.com
To: philehol...@googlemail.com; m...@philholmes.net
Cc: lilypond-devel@gnu.org; re...@codereview.appspotmail.com
Sent: Wednesday, May 25, 2011 4:50 PM
Subject: Re: Making website build almost completely quiet (issue4515042)
LGTM
On Wed, May 25, 2011 at 05:02:42PM +0100, Phil Holmes wrote:
Could you push, please?
Sure, please do
git format-origin patch
(I think -- it's been a while! actual command is in the CG)
and send me the file.
Cheers,
- Graham
___
lilypond-devel
On 2011/05/14 15:56:33, PhilEHolmes wrote:
Replies to Graham's comments. Not sure I've worked out how the review
site does
quoting yet, so apologies if this looks strange.
This looks fine.
Yeah - that's what I said in the comment on the review. All the
changes are
with respect to the
On 2011/05/15 07:08:51, Graham Percival wrote:
... wait a moment, this is your previous patch. Why are we still
discussing it?
Please close this issue, then comment on your newer google code
issue.
ok, never mind, this *is* the newer google code issue.
In your git, do
git pull -r
git
could we get a subject like add a -q quiet flag to make websit scripts
?
Also, don't mention that it includes previous patches -- that's
implicitly done everywhere in git (or any source versioning system)
http://codereview.appspot.com/4515042/diff/10001/make/website.make
File make/website.make
Replies to Graham's comments. Not sure I've worked out how the review
site does quoting yet, so apologies if this looks strange.
http://codereview.appspot.com/4515042/diff/1/make/website.make
File make/website.make (right):
