However, if you don't mind, i'd prefer to leave it as is - i have
_already_ spent about 4 hours cleaning up and rebasing commits to
make
them somewhat ordered for review, and i'm quite tired.
I do mind. this is not the sort of thing that can be done in a
follow up patch. If you don't
2013/12/10 benko@gmail.com:
However, if you don't mind, i'd prefer to leave it as is - i have
_already_ spent about 4 hours cleaning up and rebasing commits to make
them somewhat ordered for review, and i'm quite tired.
I do mind. this is not the sort of thing that can be done in a
hi Janek,
2013/12/11 Janek Warchoł janek.lilyp...@gmail.com:
2013/12/10 benko@gmail.com:
However, if you don't mind, i'd prefer to leave it as is - i have
_already_ spent about 4 hours cleaning up and rebasing commits to make
them somewhat ordered for review, and i'm quite tired.
I do
However, if you don't mind, i'd prefer to leave it as is - i have
_already_ spent about 4 hours cleaning up and rebasing commits to make
them somewhat ordered for review, and i'm quite tired.
I do mind. this is not the sort of thing that can be done in a
follow up patch. If you don't want to
i have not looked at the code, but small nit: I think you could leave
the new subdirectory for another time. 5 files (and only accidentals)
does not fix anything, and rather adds to the confusion.
https://codereview.appspot.com/38530043/
___
also, for reviewing, you should do the file reorganization and the code
reorganization in different changes.
https://codereview.appspot.com/38530043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2013/12/09 09:31:57, hanwenn wrote:
also, for reviewing, you should do the file reorganization and the
code
reorganization in different changes.
It's also a good idea to move files and change files in different
commits since git gets worse at tracking moves/renames the more changes
happen
2013/12/9 hanw...@gmail.com:
i have not looked at the code, but small nit: I think you could leave
the new subdirectory for another time. 5 files (and only accidentals)
does not fix anything, and rather adds to the confusion.
Indeed. I'll remove the subdir, but keep the split.
2013/12/9
