Re: Move get_normal to Offset::normal (issue 576000043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
On 2020/04/13 19:38:02, dak wrote: > On 2020/04/13 19:08:31, hanwenn wrote: > > > https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh > > File flower/include/offset.hh (right): > > > > > https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh#n

Re: Move get_normal to Offset::normal (issue 576000043 by hanw...@gmail.com)

2020-04-13 Thread dak
On 2020/04/13 19:08:31, hanwenn wrote: > https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh > File flower/include/offset.hh (right): > > https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh#newcode123 > flower/include/offset.hh:123: Offset

Re: Move get_normal to Offset::normal (issue 576000043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
Reviewers: dak, https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh File flower/include/offset.hh (right): https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh#newcode123 flower/include/offset.hh:123: Offset normal() const { On 2020/04/13

Move get_normal to Offset::normal (issue 576000043 by hanw...@gmail.com)

2020-04-13 Thread dak
https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh File flower/include/offset.hh (right): https://codereview.appspot.com/57643/diff/577750046/flower/include/offset.hh#newcode123 flower/include/offset.hh:123: Offset normal() const { It's kind of unusual to make a