Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-09-24 Thread pkx166h
Reviewers: Trevor Daniels, Message: On 2011/08/10 22:32:13, Trevor Daniels wrote: James My suggestion was to remove the *material* in 5.1.7 and replace it with material from 5.4.3, removing 5.4.3 as a section. The reference at the end of the material from 5.4.3 will need to be removed. Als

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-09-24 Thread tdanielsmusic
James Looks pretty good. I've made a couple of suggested additions. Could you please make a new patch with these changes in, and then I'll give it a more careful check over. Trevor http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changing-defaults.itely File Documentation

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-09-25 Thread pkx166h
New Patch set loaded with Trevor's suggestions. James http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/3001/Documentation/notation/changing-defa

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-09-26 Thread percival . music . ca
http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.itely#newcode961 Documentation/notation/changing-de

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-10-01 Thread pkx166h
On 2011/09/27 04:35:56, Graham Percival wrote: http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.i

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-10-01 Thread tdanielsmusic
A few comments, but otherwise LGTM. If you agree the changes and it compiles please push. Trevor http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-10-01 Thread percival . music . ca
I agree with everything Trevor said, including pushing after you've changed it and it compiles. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

2011-10-06 Thread pkx166h
Thanks Trevor and Graham. I also had to change an @ref in vocal.itely because the node name changed. Checked it all compiled. commit 32c862967d559ab512cd96e3321a2c8dabe724ca http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely File Documentation/nota