Re: Optimize get_path_list. (issue 579570043 by hanw...@gmail.com)

2020-04-24 Thread hanwenn
On 2020/04/13 19:11:22, hanwenn wrote: > https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc > File lily/stencil-integral.cc (right): > > https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc#newcode115 > lily/stencil-integral.cc:115: &&

Re: Optimize get_path_list. (issue 579570043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc#newcode115 lily/stencil-integral.cc:115: && (SCM_EQ_P (head, ly_symbol2scm ("moveto")) On

Optimize get_path_list. (issue 579570043 by hanw...@gmail.com)

2020-04-13 Thread dak
There is scm_c_memq for avoiding hare, but for this use case, the explicit code seems like the saner option. Even without hare, the list would be consed together each time without further measures. https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc File