Re: Part_combine_iterator: treat child iterators as a set (issue 240020043 by nine.fierce.ball...@gmail.com)

2015-05-22 Thread nine . fierce . ballads
https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (right): https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc#newcode111 lily/part-combine-iterator.cc:111: iterators_[i]->quit (); On 2015/05/22 07:4

Re: Part_combine_iterator: treat child iterators as a set (issue 240020043 by nine.fierce.ball...@gmail.com)

2015-05-22 Thread dak
Sorry for the previous empty review: somehow my comment in it got lost. https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc File lily/part-combine-iterator.cc (right): https://codereview.appspot.com/240020043/diff/20001/lily/part-combine-iterator.cc#newcode111 lily

Re: Part_combine_iterator: treat child iterators as a set (issue 240020043 by nine.fierce.ball...@gmail.com)

2015-05-22 Thread dak
https://codereview.appspot.com/240020043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Part_combine_iterator: treat child iterators as a set (issue 240020043 by nine.fierce.ball...@gmail.com)

2015-05-20 Thread nine . fierce . ballads
https://codereview.appspot.com/240020043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel