Re: Patch for issue 3882: stencils with stroke-thickness set to zero (issue 201520044 by luk.piet...@gmail.com)

2015-03-08 Thread pkx166h
author Lukas Pietsch lukas.piet...@freenet.de Sun, 8 Mar 2015 10:34:32 + (10:34 +) committer James Lowe pkx1...@gmail.com Sun, 8 Mar 2015 10:39:06 + (10:39 +) commit b7fdbfc2ceb805cfca5b386b43e1dec831702b17 (I downloaded the diff file from Rietveld

Re: Patch for issue 3882: stencils with stroke-thickness set to zero (issue 201520044 by luk.piet...@gmail.com)

2015-03-06 Thread pkx166h
Patch counted down - please push https://codereview.appspot.com/201520044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch for issue 3882: stencils with stroke-thickness set to zero (issue 201520044 by luk.piet...@gmail.com)

2015-03-04 Thread pkx166h
On 2015/03/03 18:53:18, luk.pietsch wrote: On 2015/03/03 18:34:24, J_lowe wrote: It seems to me that from the email thread on the lists this patch still needs some work. James Not that I'm aware; have I missed something? The thread where we were discussing further revisions the other

Re: Patch for issue 3882: stencils with stroke-thickness set to zero (issue 201520044 by luk.piet...@gmail.com)

2015-03-03 Thread pkx166h
Lukas, It seems to me that from the email thread on the lists this patch still needs some work. James https://codereview.appspot.com/201520044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Patch for issue 3882: stencils with stroke-thickness set to zero (issue 201520044 by luk.piet...@gmail.com)

2015-03-03 Thread luk . pietsch
On 2015/03/03 18:34:24, J_lowe wrote: It seems to me that from the email thread on the lists this patch still needs some work. James Not that I'm aware; have I missed something? The thread where we were discussing further revisions the other day was about a different patch, the one about

Re: Patch for issue 3882: stencils with stroke-thickness set to zero (issue 201520044 by luk.piet...@gmail.com)

2015-02-28 Thread pkx166h
Patchy the autobot says: passes tests. Includes a full make doc https://codereview.appspot.com/201520044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Patch for issue 3882: stencils with stroke-thickness set to zero (issue 201520044 by luk.piet...@gmail.com)

2015-02-25 Thread dak
https://codereview.appspot.com/201520044/diff/1/scm/output-ps.scm File scm/output-ps.scm (right): https://codereview.appspot.com/201520044/diff/1/scm/output-ps.scm#newcode308 scm/output-ps.scm:308: (if (or (not fill?)( thickness 0)) gsave stroke grestore ) That sounds like unnecessary effort in