Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-06 Thread pkx166h
Passes make and no reg test diffs showing. James http://codereview.appspot.com/5333051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-06 Thread dak
On 2011/11/06 04:31:23, Carl wrote: One question -- as you move from parser tokens to music functions, is the capability of displayLilyMusic being kept functional for all of these functions? Since \displayLilyMusic does not see whether the music it looks at is generated by music functions or

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-05 Thread Carl . D . Sorensen
I'd be lying if I said I understood all this in detail, but I like the big picture. If this passes regtests, I think that it's looking good. One question -- as you move from parser tokens to music functions, is the capability of displayLilyMusic being kept functional for all of these functions?

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-05 Thread Carl . D . Sorensen
On 2011/11/05 22:42:54, dak wrote: On 2011/11/05 11:56:13, J_lowe wrote: > Patch fails to apply against current master Probably Rietveld did not like me deleting a patch in the middle of the series. It is really a noisome tool. I don't think that Rietveld didn't like it. I think somebody

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-05 Thread dak
On 2011/11/05 11:56:13, J_lowe wrote: Patch fails to apply against current master Probably Rietveld did not like me deleting a patch in the middle of the series. It is really a noisome tool. I'll delete and reupload the last version. That will hopefully help. http://codereview.appspot.com/5

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-05 Thread pkx166h
Patch fails to apply against current master --snip-- jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 < ../Desktop/issue5333051_6001.diff patching file Documentation/extending/programming-interface.itely patching file input/regression/optional-args-backup.ly Hunk #1 FAILED at 4. 1 out of 1 hunk

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-04 Thread dak
On 2011/11/05 06:32:26, dak wrote: On 2011/11/05 06:15:49, dak wrote: > On 2011/11/04 23:43:04, Reinhold wrote: > > On 2011/11/03 22:59:52, J_lowe wrote: > > > Passes make and make check, No reg test diffs. > > > > Is Patch Set 3 the final version, or are the three patch sets independent > > pa

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-04 Thread dak
On 2011/11/05 06:15:49, dak wrote: On 2011/11/04 23:43:04, Reinhold wrote: > On 2011/11/03 22:59:52, J_lowe wrote: > > Passes make and make check, No reg test diffs. > > Is Patch Set 3 the final version, or are the three patch sets independent > patches that need to be applied one after the oth

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-04 Thread dak
Reviewers: J_lowe, Reinhold, Message: On 2011/11/04 23:43:04, Reinhold wrote: On 2011/11/03 22:59:52, J_lowe wrote: > Passes make and make check, No reg test diffs. Is Patch Set 3 the final version, or are the three patch sets independent patches that need to be applied one after the other?

Re: Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-04 Thread reinhold . kainhofer
On 2011/11/03 22:59:52, J_lowe wrote: Passes make and make check, No reg test diffs. Is Patch Set 3 the final version, or are the three patch sets independent patches that need to be applied one after the other??? It seems that the patch set 3 does not contain many changes from the first two pa

Patch series (available at branch dev/syntax) for more argument list power. (issue 5333051)

2011-11-03 Thread pkx166h
Passes make and make check, No reg test diffs. James http://codereview.appspot.com/5333051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel