On 2018/05/05 23:07:45, Carl wrote:
Remove debug printing
Very nice!
LGTM ofcourse
Thanks!
https://codereview.appspot.com/294570043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Carl,
apart from one nit (see below)
LGTM
Probably not related to this patch:
Clicking "Delta from patch set" gives strange results. No clue what
Rietveld does...
https://codereview.appspot.com/294570043/diff/20001/scm/translation-functions.scm
File scm/translation-functions.scm (right):
Reviewers: thomasmorley651,
Message:
Harm,
Thanks for the great comments.
If the user doesn't want the barre to be displayed, they can avoid it by
setting fret-diagram-details.barre-type = #'none
Thanks,
Carl
https://codereview.appspot.com/294570043/diff/1/scm/translation-functions.scm
Hi Carl,
nice work.
A general thought:
As far as I understand the code will work automatically. Though, I
foresee some users wanting to switch it off (ofcourse not the majority,
but there is always somebody with different wishes).
Any chance to create an option for it?
Some inline remarks
