Re: fret diagram comments

On Wed, Jun 25, 2008 at 3:51 PM, Carl D. Sorensen <[EMAIL PROTECTED]> wrote: > > >> -Original Message- >> From: Han-Wen Nienhuys [mailto:[EMAIL PROTECTED] >> Sent: Wednesday, June 25, 2008 3:11 AM >> To: Carl D. Sorensen >> Cc: lily-devel >>

RE: fret diagram comments

> -Original Message- > From: Han-Wen Nienhuys [mailto:[EMAIL PROTECTED] > Sent: Wednesday, June 25, 2008 3:11 AM > To: Carl D. Sorensen > Cc: lily-devel > Subject: Re: fret diagram comments > > a few nits; please apply after fixing those (maybe in a > separate

Re: fret diagram comments

a few nits; please apply after fixing those (maybe in a separate commit). - sans-serif-stencil. is this a markup function? If yes, put in define-markup.scm - (finger-yoffset (- (* size 0.5))) -> (* -0.5 size) + " Put together a fret-list in the format desired by parse-string " drop

RE: fret diagram comments

Han-Wen, I've got one patch that has all the changes and nothing else available on the csorensen fork. The URL is http://repo.or.cz/w/lilypond/csorensen.git The fret-diagram-details is the branch you want. The "Move fret diagram specific properties" commit should work properly. The code has

Re: fret diagram comments

On Mon, Jun 23, 2008 at 5:41 PM, Carl D. Sorensen <[EMAIL PROTECTED]> wrote: >> I am fine with mixing formatting and real code if it's >> limited to a specific area (the fret code). If you are >> modifying all of the SCM code (eg reindenting >> define-grobs.scm) it would be nice if that happened i

RE: fret diagram comments

> -Original Message- > From: Han-Wen Nienhuys [mailto:[EMAIL PROTECTED] > Sent: Monday, June 23, 2008 7:22 AM > To: Carl D. Sorensen > Cc: lily-devel > Subject: Re: fret diagram comments > > > I am fine with mixing formatting and real code if it's > l

Re: fret diagram comments

On Sun, Jun 22, 2008 at 2:51 PM, Carl D. Sorensen <[EMAIL PROTECTED]> wrote: >> Sure, but it is good practice to not mix the formatting >> cleanups and functional cleanups in the same code. > > OK. So right now I have some functionally changed code with ugly formatting > that passes the regressi

RE: fret diagram comments

> -Original Message- > From: Han-Wen Nienhuys [mailto:[EMAIL PROTECTED] > Sent: Sunday, June 22, 2008 5:31 AM > To: Carl D. Sorensen > Cc: lily-devel > Subject: Re: fret diagram comments > > On Sun, Jun 22, 2008 at 5:07 AM, Carl D. Sorensen > <[EMAIL PR

Re: fret diagram comments

On Sun, Jun 22, 2008 at 5:07 AM, Carl D. Sorensen <[EMAIL PROTECTED]> wrote: > I will be happy to clean up the formatting. I can see that the code lines > are too long, > which give lots of random wraps and hides the structure. > > I intend to reformat the code, by using two-space indents where t

RE: fret diagram comments

> -Original Message- > From: Carl D. Sorensen > Sent: Saturday, June 21, 2008 5:18 PM > To: '[EMAIL PROTECTED]'; lily-devel > Subject: RE: fret diagram comments > > > > > -Original Message- > > From: Han-Wen Nienhuys [mailto:[EMAIL

RE: fret diagram comments

> -Original Message- > From: Han-Wen Nienhuys [mailto:[EMAIL PROTECTED] > Sent: Saturday, June 21, 2008 4:17 PM > To: lily-devel > Subject: fret diagram comments > > hi Carl, > > here some quick notes on the fret diagram code. I am not > familiar with frets, so I have little comment on