On 2011/03/07 19:48:23, J_lowe wrote:
Layout wise - Looks fine.
Colin,
From: Colin Campbell [mailto:c...@shaw.ca]
Sent: 10 March 2011 13:57
To: James Lowe
Subject: Fwd: part combine doc patch
Good morning, James
Attached is a patch which needs pushing, if you would oblige
---
Layout wise - Looks fine.
http://codereview.appspot.com/4188056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM, apart from a minor nitpick in original text
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (left):
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871
Documentation/notation/simultaneous.itely:871:
On 2011/03/06 12:13:15, Reinhold wrote:
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871
Patch revised to remove the doc-section.sh bits which were pushed
separately. The remainder is just the partcombine explanation.
Ordinarily, I suppose this needn't go on reitveld, but wotthehell
archie, it started here so I'm putting the last bit up to close out the
process.
http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh
File scripts/auxiliar/doc-section.sh (right):
http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh#newcode33
scripts/auxiliar/doc-section.sh:33: FROMDIR=$HOME/lilypond-git
I totally
...@gmail.com
Cc: re...@codereview.appspotmail.com; lilypond-devel@gnu.org
Subject: Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
On 2011/02/24 04:29:24, Colin Campbell
Perhaps I should add something like: decide, but the results may need
adjustment
in some cases.?
Yes
Actually thinking about it more would it make more sense to have the
auto
function listed first then add the words ... May need some manual
adjustment.'
and then list the rest?
James
I like that very much, James, thanks! A question for Reinhold, though:
do I gather correctly that
On 2011/02/26 20:01:39, Colin Campbell wrote:
I like that very much, James, thanks! A question for Reinhold,
though: do I
gather correctly that \partcombine is applied to a Staff, and turns
the
combining mechanism on, while \partcombineAutomatic is applied to a
single
Voice? That being
Am Samstag, 26. Februar 2011, um 21:01:40 schrieben Sie:
A question for Reinhold, though:
do I gather correctly that \partcombine is applied to a Staff, and turns
the combining mechanism on, while \partcombineAutomatic is applied to a
single Voice?
Not really. When part-combining does its
On 2011/02/24 04:29:24, Colin Campbell
Perhaps I should add something like: decide, but the results may need
adjustment
in some cases.?
Yes that sounds like a better way of putting it.
http://codereview.appspot.com/4188056/
___
lilypond-devel
On 2011/02/22 12:15:31, Reinhold wrote:
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode852
one correction.
http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely#newcode820
http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/2004/Documentation/notation/simultaneous.itely#newcode820
Documentation/notation/simultaneous.itely:820:
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode852
Documentation/notation/simultaneous.itely:852:
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846
Documentation/notation/simultaneous.itely:846:
revised patch uploaded.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846
On 2011/02/16 06:08:03, Keith wrote:
Looks good as it is,
better if you can add one markup that Reinhold missed in the example.
http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
LGTM.
http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely#newcode846
Documentation/notation/simultaneous.itely:846:
Looks good as it is,
better if you can add one markup that Reinhold missed in the example.
http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
21 matches
Mail list logo
