LGTM.
http://codereview.appspot.com/4801083/diff/14002/scm/define-grobs.scm
File scm/define-grobs.scm (right):
http://codereview.appspot.com/4801083/diff/14002/scm/define-grobs.scm#newcode933
scm/define-grobs.scm:933: (end-on-accidental . #t)
trailing whitespace
http://codereview.appspot.com/4
On Aug 9, 2011, at 10:04 PM, n.putt...@gmail.com wrote:
> On 2011/08/09 18:23:42, mike_apollinemike.com wrote:
>
>> Good call - I've uploaded a new patch that uses "accidental-grob"
> (don't know
>> why I didn't think of that before...too much code on the brain!).
>
> The latest patch set needs
On 2011/08/09 18:23:42, mike_apollinemike.com wrote:
Good call - I've uploaded a new patch that uses "accidental-grob"
(don't know
why I didn't think of that before...too much code on the brain!).
The latest patch set needs rebasing against master.
Cheers,
Neil
http://codereview.appspot.co
On Aug 9, 2011, at 7:15 PM, n.putt...@gmail.com wrote:
> http://codereview.appspot.com/4801083/diff/8001/lily/line-spanner.cc#newcode113
> lily/line-spanner.cc:113: Grob *acc = Note_column::accidentals
> (bound_grob->get_parent (X_AXIS));
> acc is an AccidentalPlacement, so should be renamed to av
http://codereview.appspot.com/4801083/diff/8001/input/regression/glissando-accidental.ly
File input/regression/glissando-accidental.ly (right):
http://codereview.appspot.com/4801083/diff/8001/input/regression/glissando-accidental.ly#newcode8
input/regression/glissando-accidental.ly:8: a1 \glissa
On 9 August 2011 07:41, wrote:
> On 2011/08/09 05:08:56, hanwenn wrote:
>>
>> LGTM
>
>> note that image of the issue will also require a minimum distance
>
> setting,
>>
>> otherwise, the glissando will be shortened into a dot?
>
> Done. New patchset uploaded.
This doesn't ensure the glissando'
On 2011/08/09 05:08:56, hanwenn wrote:
LGTM
note that image of the issue will also require a minimum distance
setting,
otherwise, the glissando will be shortened into a dot?
Done. New patchset uploaded.
Cheers,
MS
http://codereview.appspot.com/4801083/
_
LGTM
note that image of the issue will also require a minimum distance
setting, otherwise, the glissando will be shortened into a dot?
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/
LGTM.
Thanks,
Carl
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/08/08 15:19:06, Carl wrote:
Can we have a regtest, please?
Regtest added.
Cheers,
MS
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Can we have a regtest, please?
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Pass make and reg tests
http://codereview.appspot.com/4801083/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
12 matches
Mail list logo