Redo autobeam settings to make resetting easier (issue1667041)

2010-06-12 Thread Carl . D . Sorensen
Reviewers: , Message: I have *finally* completed the autobeaming patch. The patch eliminates beamSettings as a major alist containing settings for various time signatures. Instead, autobeaming is controlled by some simple context properties: beamSettings, beatLength, and measureGrouping. In o

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-13 Thread Trevor Daniels
Carl At first glance this looks like a major improvement! I'm tied up today, but I'll give it a whirl within a day or two. Trevor - Original Message - From: To: Cc: ; Sent: Sunday, June 13, 2010 2:47 AM Subject: Redo autobeam settings to make resetting easier (is

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-13 Thread n . puttock
Hi Carl, Are you sure this is ready for review? I see comments like this, // I removed this to solve a bug; need to make sure it's right -- cds and commented debug code, +;(display "\nIn auto-beam.scm\n") and alarm bells start to ring. :) Also, there are several places where beamSettings is

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-13 Thread Carl Sorensen
On 6/13/10 1:01 PM, "n.putt...@gmail.com" wrote: > Hi Carl, > > Are you sure this is ready for review? > > I see comments like this, > > // I removed this to solve a bug; need to make sure it's right -- cds Oh, yeah. I forgot that I had done that. I didn't put it in my notes when I was work

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Trevor Daniels
`include/beam-settings.hh', needed by `out/beaming-pattern.o'. Stop. make[1]: Leaving directory `/media/Data/lily' make: *** [all] Error 2 Trevor - Original Message - From: To: Cc: ; Sent: Sunday, June 13, 2010 2:47 AM Subject: Redo autobeam settings to make resett

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Carl Sorensen
ngs.hh', > needed by `out/beaming-pattern.o'. Stop. > make[1]: Leaving directory `/media/Data/lily' > make: *** [all] Error 2 > > Trevor > > ----- Original Message - > From: > To: > Cc: ; > Sent: Sunday, June 13, 2010 2:47 AM > Subject: Redo a

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread n . puttock
Hi Trevor, On 2010/06/14 18:18:21, t.daniels_treda.co.uk wrote: I downloaded and applied Patch set 1, but make failed with make[2]: Leaving directory `/media/Data/flower/include' make[1]: Leaving directory `/media/Data/flower' make[1]: Entering directory `/media/Data/lily' rm -f ./out/auto-b

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Carl Sorensen
On 6/14/10 1:00 PM, "Graham Percival" wrote: > On Mon, Jun 14, 2010 at 06:28:15PM +, n.putt...@gmail.com wrote: >> I had to run `make bin-clean' and recompile to get round this. > > Please tell me that "bin-clean" doesn't do anything that: > make doc-clean > make clean >

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Graham Percival
On Mon, Jun 14, 2010 at 06:28:15PM +, n.putt...@gmail.com wrote: > I had to run `make bin-clean' and recompile to get round this. Please tell me that "bin-clean" doesn't do anything that: make doc-clean make clean make distclean doesn't do. (ok, time to edit the CG aga

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Neil Puttock
On 14 June 2010 20:04, Carl Sorensen wrote: > bin-clean should just clean up the binaries. Yup, it saves having to rebuild fonts, so in this case shaves off a significant proportion of the total build time. > make doc-clean is documentation + fonts, I think. Docs only. Cheers, Neil _

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Graham Percival
On Mon, Jun 14, 2010 at 01:04:46PM -0600, Carl Sorensen wrote: > make distclean is everything, as I understand it. Doesn't do doc stuff. Might not do other stuff, as well. > > (ok, time to edit the CG again...) > > Hence the chapter on the build system that I proposed... If anything needs to b

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Trevor Daniels
Neil Puttock wrote 14 June 2010 On 14 June 2010 20:04, Carl Sorensen wrote: bin-clean should just clean up the binaries. Yup, it saves having to rebuild fonts, so in this case shaves off a significant proportion of the total build time. I saw this just after doing make clean, make. Sure

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Carl Sorensen
On 6/14/10 4:00 PM, "Trevor Daniels" wrote: > > > Neil Puttock wrote 14 June 2010 >> On 14 June 2010 20:04, Carl Sorensen wrote: >> >>> bin-clean should just clean up the binaries. >> >> Yup, it saves having to rebuild fonts, so in this case shaves off >> a >> significant proportion of th

Re: Redo autobeam settings to make resetting easier (issue1667041)

2010-06-14 Thread Trevor Daniels
Carl Sorensen wrote Tuesday, June 15, 2010 12:01 AM On 6/14/10 4:00 PM, "Trevor Daniels" wrote: Neil Puttock wrote 14 June 2010 On 14 June 2010 20:04, Carl Sorensen wrote: bin-clean should just clean up the binaries. Yup, it saves having to rebuild fonts, so in this case shaves off