Re: Remove 'thickness from LedgerLineSpanner interface. (issue 12945044)

2013-08-18 Thread janek . lilypond
LGTM https://codereview.appspot.com/12945044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Remove 'thickness from LedgerLineSpanner interface. (issue 12945044)

2013-08-15 Thread markpolesky
On 2013/08/15 07:24:48, dak wrote: That documentation states as first entry: @ref{…} — link within current manual. Well, shoot. That's why we have a countdown. Sorry for the mistake. Just, um, asserting my humanity, I guess... Anyway, I made the change. - Mark https://codereview.appspot

Re: Remove 'thickness from LedgerLineSpanner interface. (issue 12945044)

2013-08-15 Thread dak
On 2013/08/15 06:59:58, Mark Polesky wrote: On 2013/08/14 21:35:16, Trevor Daniels wrote: > Should this not be @ref{...}? No. @rinternals{...}. See http://lilypond.org/doc/v2.17/Documentation/contributor/syntax-survey#cross-references - Mark That documentation states as first entry: @

Re: Remove 'thickness from LedgerLineSpanner interface. (issue 12945044)

2013-08-15 Thread markpolesky
Reviewers: Trevor Daniels, Message: On 2013/08/14 21:35:16, Trevor Daniels wrote: Should this not be @ref{...}? No. @rinternals{...}. See http://lilypond.org/doc/v2.17/Documentation/contributor/syntax-survey#cross-references - Mark Description: Remove 'thickness from LedgerLineSpanner inte

Remove 'thickness from LedgerLineSpanner interface. (issue 12945044)

2013-08-14 Thread tdanielsmusic
LGTM, apart from a query https://codereview.appspot.com/12945044/diff/1/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): https://codereview.appspot.com/12945044/diff/1/lily/ledger-line-spanner.cc#newcode331 lily/ledger-line-spanner.cc:331: " property of the @rinternals{Staf