Re: Remove @ substitutions from python/*.py (issue 549740043 by hanw...@gmail.com)

2020-03-21 Thread Dan Eble
On Mar 21, 2020, at 08:25, hanw...@gmail.com wrote: > > For context: many projects that I contribute to keep harping about > trailing whitespace I recently started using the ws-butler package to limit whitespace changes to lines that also have substantive changes. It has helped me.

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanw...@gmail.com)

2020-03-21 Thread hanwenn
On 2020/03/21 11:22:15, hahnjo wrote: > On 2020/03/21 11:16:12, hanwenn wrote: > > PTAL > > Very please don't clutter diffs with unrelated whitespace changes. If you think > we should apply this, please do so independently. After a message to > lilypond-devel they can probably go into staging ->

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanw...@gmail.com)

2020-03-21 Thread jonas . hahnfeld
On 2020/03/21 11:16:12, hanwenn wrote: > PTAL Very please don't clutter diffs with unrelated whitespace changes. If you think we should apply this, please do so independently. After a message to lilypond-devel they can probably go into staging -> master directly without much review. Also please

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanw...@gmail.com)

2020-03-21 Thread hanwenn
PTAL https://codereview.appspot.com/549740043/

Re: Remove @ substitutions from python/*.py (issue 549740043 by hanw...@gmail.com)

2020-03-21 Thread hanwenn
Reviewers: hahnjo, Message: On 2020/03/21 08:56:20, hahnjo wrote: > Could you please copy the comment to all places where you paste the code? sure. Note that the comment is just paraphrasing the documentation for gettext.install https://docs.python.org/3/library/gettext.html Description:

Remove @ substitutions from python/*.py (issue 549740043 by hanw...@gmail.com)

2020-03-21 Thread jonas . hahnfeld
Could you please copy the comment to all places where you paste the code? https://codereview.appspot.com/549740043/