Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-04-09 Thread hanwenn
commit f342a35bb1f4ab7c85e13a344a126eece38993fb (test-output-dist) Author: Han-Wen Nienhuys Date: Sun Mar 29 18:52:50 2020 +0200 Remove references to test-output-distance.ly. https://codereview.appspot.com/549780044/

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-30 Thread Dan Eble
On Mar 30, 2020, at 17:34, Han-Wen Nienhuys wrote: > > On Sun, Mar 29, 2020 at 11:45 PM Dan Eble wrote: >> >> On Mar 29, 2020, at 17:39, Han-Wen Nienhuys wrote: test-output-distance was removed on the grounds that the self-test serves the same purpose, but I don't see how it does.

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-30 Thread Han-Wen Nienhuys
On Sun, Mar 29, 2020 at 11:45 PM Dan Eble wrote: > > On Mar 29, 2020, at 17:39, Han-Wen Nienhuys wrote: > >> test-output-distance was removed on the grounds that the self-test > >> serves the same purpose, but I don't see how it does. > > > > Could you elaborate? What failure scenario are you

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-29 Thread Carl Sorensen
On 3/29/20, 3:39 PM, "lilypond-devel on behalf of Han-Wen Nienhuys" wrote: On Sun, Mar 29, 2020 at 11:33 PM wrote: > > > Remove references to test-output-distance.ly. > > > > It was removed in commit 8a74a0e ("Remove > > input/regression/test-output-distance.ly")

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-29 Thread Dan Eble
On Mar 29, 2020, at 17:39, Han-Wen Nienhuys wrote: >> test-output-distance was removed on the grounds that the self-test >> serves the same purpose, but I don't see how it does. > > Could you elaborate? What failure scenario are you worried about? My question is, how does the self-test "verify

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-29 Thread Han-Wen Nienhuys
On Sun, Mar 29, 2020 at 11:33 PM wrote: > > > Remove references to test-output-distance.ly. > > > > It was removed in commit 8a74a0e ("Remove > > input/regression/test-output-distance.ly") > > I must have slept through that. Had I been paying attention, I would > have pointed out what the

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-29 Thread nine . fierce . ballads
> Remove references to test-output-distance.ly. > > It was removed in commit 8a74a0e ("Remove > input/regression/test-output-distance.ly") I must have slept through that. Had I been paying attention, I would have pointed out what the documentation you propose to remove says: This test

Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-29 Thread jonas . hahnfeld
https://codereview.appspot.com/549780044/diff/553810043/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): https://codereview.appspot.com/549780044/diff/553810043/Documentation/contributor/regressions.itexi#newcode240