Re: Remove special case in staff-spacing (issue4188051)

2011-08-07 Thread Janek Warchoł
After thinking and thinking, i think i know now what's the answer :) 2011/8/5 Janek Warchoł : > 2011/8/3  : >> On 2011/08/02 21:29:24, Janek Warchol wrote: >>> note-head-chord [...] it's gone a bit too far in this case. >> >> We could adjust the spacing parameters.  Do you think the gap is to >> s

Re: Remove special case in staff-spacing (issue4188051)

2011-08-03 Thread k-ohara5a5a
On 2011/08/02 21:29:24, Janek Warchol wrote: It does the things i hoped for for ages :) It merely restores the spacing rules LilyPond had through version 2.10.20 or so. See almost anything on mutopiaproject, I also see some differ

Re: Remove special case in staff-spacing (issue4188051)

2011-08-02 Thread Janek Warchoł
Keith, sorry for the delayed answer, i had to sort out my repository because of grand-fixccing, and didn't know how to open eps files that are created by regtests (eventually i compiled a few suspicious regtests by hand). In general, your patch is wonderful! It does the things i hoped for for age

Re: Remove special case in staff-spacing (issue4188051)

2011-07-30 Thread k-ohara5a5a
On 2011/07/30 15:18:58, Janek Warchol wrote: 2011/7/29 : > > The old code first ensured that accidentals were at least > 0.3-space away from the barline, and then added the > full-measure-extra-space on top of that. I'm not sure if you achieved what you meant. Oops. Right. Thanks. I had i

Re: Remove special case in staff-spacing (issue4188051)

2011-07-28 Thread k-ohara5a5a
On 2011/07/29 04:31:00, Janek Warchol wrote: Could you add some comments for rookies like me (the more, the better)? Some explanatory comments. (English takes a lot more space than C.) http://codereview.appspot.com/4188051/diff/17001/lily/spacing-spanner.cc File lily/spacing-spanner.cc (righ

Re: Remove special case in staff-spacing (issue4188051)

2011-07-28 Thread lemniskata . bernoullego
Keith, I am so sorry - you've sent me this patch ages ago and i forgot about it! :( I've checked regtests to see how it works and it's great!! However, i cannot write any meaningful review, because i don't understand what's going on here at all :( Could you add some comments for rookies like me

Re: Remove special case in staff-spacing (issue4188051)

2011-07-27 Thread k-ohara5a5a
http://codereview.appspot.com/4188051/diff/4001/lily/include/spacing-spanner.hh#newcode45 lily/include/spacing-spanner.hh:45: static Real cushion_; I think this should be a grob property rather than a static variable. New patch set up, simpler, no longer involves any static variable. http://c

Re: Remove special case in staff-spacing (issue4188051)

2011-07-25 Thread k-ohara5a5a
Reviewers: J_lowe, joeneeman, Message: lily/include/spacing-spanner.hh:45: static Real cushion_; I think this should be a grob property rather than a static variable. I'm scared of the property-lookup costs. I might be wiser to leave it where it was in Springs::merge() , and just apply full-

Re: Remove special case in staff-spacing (issue4188051)

2011-07-25 Thread joeneeman
http://codereview.appspot.com/4188051/diff/4001/lily/include/spacing-spanner.hh File lily/include/spacing-spanner.hh (right): http://codereview.appspot.com/4188051/diff/4001/lily/include/spacing-spanner.hh#newcode45 lily/include/spacing-spanner.hh:45: static Real cushion_; I think this should be

Remove special case in staff-spacing (issue4188051)

2011-07-25 Thread pkx166h
Passes make and there are lots (lots) of reg test differences but as keith says many 'small' ones, nothing immediately jumps out as bad. But I cannot figure out how to attach them here for others to see. A pdf > 20MB and making screen shots is not really appropriate (there would be about 60+ pngs