Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-27 Thread hanwenn
commit 2ddc627c3c3e0299c4dc0ba109340cff54c49710 Author: Han-Wen Nienhuys Date: Sat Mar 21 13:13:32 2020 +0100 Remove trailing whitespace in {python,scripts,*make*}. https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-22 Thread jonas . hahnfeld
On 2020/03/21 19:18:26, hanwenn wrote: > On Sat, Mar 21, 2020 at 8:10 PM wrote: > > > > On 2020/03/21 19:09:01, hanwenn wrote: > > > You suggested it yourself? I removed the lily/ and scm/ changes to > > > avoid conflicts. > > > > huh!? "maybe we can combine this w

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread Han-Wen Nienhuys
On Sat, Mar 21, 2020 at 8:10 PM wrote: > > On 2020/03/21 19:09:01, hanwenn wrote: > > You suggested it yourself? I removed the lily/ and scm/ changes to > > avoid conflicts. > > huh!? "maybe we can combine this with running fixcc.py?" doesn't sound > like "please push immediately"! "After a messa

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread jonas . hahnfeld
On 2020/03/21 19:09:01, hanwenn wrote: > You suggested it yourself? I removed the lily/ and scm/ changes to > avoid conflicts. huh!? "maybe we can combine this with running fixcc.py?" doesn't sound like "please push immediately"! https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread Han-Wen Nienhuys
You suggested it yourself? I removed the lily/ and scm/ changes to avoid conflicts. On Sat, Mar 21, 2020 at 7:38 PM wrote: > > On 2020/03/21 18:20:09, hanwenn wrote: > > As discussed, will push this without countdown. > > Discussed where? David proposed on lilypond-devel to run fixcc.py > tomorro

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread jonas . hahnfeld
On 2020/03/21 18:20:09, hanwenn wrote: > As discussed, will push this without countdown. Discussed where? David proposed on lilypond-devel to run fixcc.py tomorrow, but I see no reference to this patch. https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread Han-Wen Nienhuys
As discussed, will push this without countdown. On Sat, Mar 21, 2020 at 3:36 PM wrote: > > On 2020/03/21 13:14:50, hahnjo wrote: > > Sending to lilypond-devel for broader notice. This is likely to give > conflicts, > > maybe we can combine this with running fixcc.py? > > I've backed out scm and l

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread hanwenn
On 2020/03/21 13:14:50, hahnjo wrote: > Sending to lilypond-devel for broader notice. This is likely to give conflicts, > maybe we can combine this with running fixcc.py? I've backed out scm and lily so it won't give conflicts with fixcc and fixscm. https://codereview.appspot.com/547810043/

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread dak
On 2020/03/21 14:17:03, dak wrote: > On 2020/03/21 13:14:50, hahnjo wrote: > > Sending to lilypond-devel for broader notice. This is likely to give > conflicts, > > maybe we can combine this with running fixcc.py? > > Ah right, that one was still pending anyway. I think it would take care of > tr

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread dak
On 2020/03/21 13:14:50, hahnjo wrote: > Sending to lilypond-devel for broader notice. This is likely to give conflicts, > maybe we can combine this with running fixcc.py? Ah right, that one was still pending anyway. I think it would take care of trailing spaces in the C++ files. https://coderevi

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

2020-03-21 Thread jonas . hahnfeld
Sending to lilypond-devel for broader notice. This is likely to give conflicts, maybe we can combine this with running fixcc.py? https://codereview.appspot.com/547810043/