Re: Revised autobeam settings patch (issue1682049)

2010-08-02 Thread Arno Waschk
On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen c_soren...@byu.edu wrote: On 8/1/10 10:33 AM, Arno Waschk hamama...@gmx.de wrote: dear list, i am *completely* confused by this autobeaming thing and especially its documentation. even after reading it twice i do not have a clue how to

Re: Revised autobeam settings patch (issue1682049)

2010-08-02 Thread Arno Waschk
On Mon, 02 Aug 2010 09:43:48 +0200, Arno Waschk hamama...@gmx.de wrote: On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen c_soren...@byu.edu wrote: On 8/1/10 10:33 AM, Arno Waschk hamama...@gmx.de wrote: dear list, i am *completely* confused by this autobeaming thing and especially its

Re: Revised autobeam settings patch (issue1682049)

2010-08-02 Thread Carl Sorensen
On 8/2/10 1:43 AM, Arno Waschk hamama...@gmx.de wrote: On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen c_soren...@byu.edu wrote: Do you want all durations of beams to be whole bar beams? If so, simply do \set beatStructure = #'(8) this is what i tried. does not work for the

Re: Revised autobeam settings patch (issue1682049)

2010-08-02 Thread Carl Sorensen
On 8/2/10 1:47 AM, Arno Waschk hamama...@gmx.de wrote: On Mon, 02 Aug 2010 09:43:48 +0200, Arno Waschk hamama...@gmx.de wrote: On Mon, 02 Aug 2010 03:04:35 +0200, Carl Sorensen c_soren...@byu.edu wrote: Do you want only the tuplets to have whole bar beams, then you'll need to set

Re: Revised autobeam settings patch (issue1682049)

2010-08-02 Thread Carl Sorensen
On 8/1/10 10:33 AM, Arno Waschk hamama...@gmx.de wrote: dear list, i am *completely* confused by this autobeaming thing and especially its documentation. even after reading it twice i do not have a clue how to practically use those things. it rather appears as a highly complex mixture

Re: Revised autobeam settings patch (issue1682049)

2010-08-01 Thread Arno Waschk
dear list, i am *completely* confused by this autobeaming thing and especially its documentation. even after reading it twice i do not have a clue how to practically use those things. it rather appears as a highly complex mixture of *either* telling me what instructions and value exists

Re: Revised autobeam settings patch (issue1682049)

2010-08-01 Thread Carl Sorensen
On 8/1/10 10:33 AM, Arno Waschk hamama...@gmx.de wrote: dear list, i am *completely* confused by this autobeaming thing and especially its documentation. even after reading it twice i do not have a clue how to practically use those things. it rather appears as a highly complex mixture of

Re: Revised autobeam settings patch (issue1682049)

2010-07-29 Thread n . puttock
On 2010/07/13 15:02:56, Carl wrote: On 2010/07/11 23:31:50, Neil Puttock wrote: beam-type ? I think not, because we're not talking about an argument to a function call or an entry in an alist here. We're talking about something that comes from the music. But I could be convinced

Re: Revised autobeam settings patch (issue1682049)

2010-07-13 Thread Carl . D . Sorensen
Thanks for the careful review! Carl http://codereview.appspot.com/1682049/diff/35001/36004 File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/1682049/diff/35001/36004#newcode1055 Documentation/notation/rhythms.itely:1055: predefined default values for these

Re: Revised autobeam settings patch (issue1682049)

2010-07-13 Thread Carl . D . Sorensen
A new patch set has been uploaded. Thanks, Carl http://codereview.appspot.com/1682049/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Revised autobeam settings patch (issue1682049)

2010-07-12 Thread Carl . D . Sorensen
On 2010/07/11 23:31:50, Neil Puttock wrote: Hi Carl, LGTM. The web snippet granados.ly uses beatLength, so will also need emending. Cheers, Neil THanks for catching that, Neil. I've fixed it as well (including updating the version). As soon as my make doc run is complete (assuming

Re: Revised autobeam settings patch (issue1682049)

2010-07-11 Thread n . puttock
Hi Carl, LGTM. The web snippet granados.ly uses beatLength, so will also need emending. Cheers, Neil http://codereview.appspot.com/1682049/diff/35001/36004 File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/1682049/diff/35001/36004#newcode1055

Re: Revised autobeam settings patch (issue1682049)

2010-07-07 Thread n . puttock
On 2010/07/07 05:53:33, Carl wrote: Yes, I have that on my to-do list. I think waiting for a separate patch makes sense. I'd love to see your patch for \ottava to help me get this right. I've just posted it here: http://codereview.appspot.com/1695052/show I think you can follow a similar

Re: Revised autobeam settings patch (issue1682049)

2010-07-07 Thread n . puttock
On 2010/07/07 05:55:07, Carl wrote: (seeing as this naming convention will have to be changed)? What does this mean? I can't remember where I read it, but I was under the impression that once GLISS starts, we'd have to think about deprecating the use of `override' and `revert' as part of

Re: Revised autobeam settings patch (issue1682049)

2010-07-06 Thread n . puttock
Hi Carl, This looks really good. A few comments: The regtests fail on beam-beat-grouping.ly, since it uses \setBeatGrouping to set the obsolete property beamSettings. The display method for \time is broken due to using ApplyContext (this is the same problem as issue 765 for \ottava, which

Re: Revised autobeam settings patch (issue1682049)

2010-07-06 Thread Carl . D . Sorensen
On 2010/07/07 00:52:10, Neil Puttock wrote: Hi Carl, This looks really good. Thanks! The regtests fail on beam-beat-grouping.ly, since it uses \setBeatGrouping to set the obsolete property beamSettings. Dang! I know I fixed that once, but maybe I did it after running makelsr.py, and

Re: Revised autobeam settings patch (issue1682049)

2010-07-06 Thread Carl . D . Sorensen
I've responded to each of Neil's comments below. I'll post another patch set once I've proven that the regtests and the docs build properly. THanks, Carl http://codereview.appspot.com/1682049/diff/3035/9004 File Documentation/notation/rhythms.itely (right):

Re: Revised autobeam settings patch (issue1682049)

2010-07-05 Thread Trevor Daniels
patch or onto current git? Trevor - Original Message - From: carl.d.soren...@gmail.com To: carl.d.soren...@gmail.com Cc: re...@codereview.appspotmail.com; lilypond-devel@gnu.org Sent: Monday, July 05, 2010 6:23 AM Subject: Revised autobeam settings patch (issue1682049) Reviewers

Re: Revised autobeam settings patch (issue1682049)

2010-07-05 Thread Carl . D . Sorensen
OK, I've loaded patch set 2. This patch set makes a clean doc build. To make this patch work, you'll need to do the following: 1) Apply the patch 2) Clean out the old binaries: make bin-clean or rm lily/out/* 3) Update the snippets in Documentation/snippets from

Revised autobeam settings patch (issue1682049)

2010-07-04 Thread Carl . D . Sorensen
Reviewers: , Message: I've posted a new patch for review that has the new autobeaming code. We now have three properties to control autobeaming: baseMoment (which sets the smallest time interval used for defining beaming), beatStructure (which defines the grouping of baseMoment intervals to