: Monday, August 08, 2011 10:32 PM
Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
Since you pushed it, James, could you correct the \typewriter to
\with-url ? Before you push, compile it on the command-line to
make sure you have the right syntax and you have a clickable link.
Cheers
On 9 August 2011 09:47, Phil Holmes em...@philholmes.net wrote:
I said in a separate message that this isn't necessary. The link is
automatically converted to a clickable link.
This only works reliably with Adobe Reader.
Foxit produces an incorrect link: mutopia.org/It (it picks up the
start
-hrn-3.ly (issue4811066)
LGTM. My comment is a tiny nitpick; I don't think it needs to hold up
pushing this.
http://codereview.appspot.com/4811066/diff/8003/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
http://codereview.appspot.com/4811066/diff/8003/input
;
)n.putt...@gmail.com; m...@philholmes.net; em...@philholmes.net;
)lilypond-devel@gnu.org; re...@codereview.appspotmail.com
)Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)- Original Message -
)From: percival.music...@gmail.com
)To: philehol...@googlemail.com; n.putt...@gmail.com
Holmes; philehol...@googlemail.com;
)percival.music...@gmail.com; n.putt...@gmail.com;
)m...@philholmes.net; lilypond-devel@gnu.org;
)re...@codereview.appspotmail.com
)Subject: RE: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)Importance: Low
)
)I'll push it.
)
)james
)
))-Original Message
...@gmail.com; n.putt...@gmail.com; m...@philholmes.net;
lilypond-devel@gnu.org; re...@codereview.appspotmail.com
Sent: Monday, August 08, 2011 4:13 PM
Subject: RE: Rewrite regtest mozart-hrn-3.ly (issue4811066)
I'll push it.
james
)-Original Message-
)From: lilypond-devel-bounces+james.lowe
)Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)
)Woh. There's an error - \url isn't part of Lilypond syntax! I'd corrected
this
)to GP, but here's a corrected patch.
)
)--
)Phil Holmes
)
)
)- Original Message -
)From: James Lowe james.l...@datacore.com
)To: Phil Holmes em
mozart-hrn-3.ly (issue4811066)
Woh. There's an error - \url isn't part of Lilypond syntax! I'd corrected
this to GP, but here's a corrected patch.
It's a bit blind leading the partially sighted here.
I cannot apply this patch because I've already applied the original one.
So can you reset
On Mon, Aug 08, 2011 at 04:45:49PM +0100, Phil Holmes wrote:
Woh. There's an error - \url isn't part of Lilypond syntax! I'd
corrected this to GP, but here's a corrected patch.
apparently the command is called
\with-url
instead.
Cheers,
- Graham
: Rewrite regtest mozart-hrn-3.ly (issue4811066)
Phil,
From: Phil Holmes [m...@philholmes.net]
Sent: 08 August 2011 16:45
To: James Lowe; philehol...@googlemail.com; percival.music...@gmail.com;
n.putt...@gmail.com; lilypond-devel@gnu.org;
re
; n.putt...@gmail.com; lilypond-
)de...@gnu.org; re...@codereview.appspotmail.com
)Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)- Original Message -
)From: James Lowe james.l...@datacore.com
)To: Phil Holmes m...@philholmes.net;
)philehol...@googlemail.com; percival.music
; n.putt...@gmail.com; lilypond-
)de...@gnu.org; re...@codereview.appspotmail.com
)Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
)
)- Original Message -
)From: James Lowe james.l...@datacore.com
)To: Phil Holmes m...@philholmes.net;
)philehol...@googlemail.com; percival.music
LGTM. My comment is a tiny nitpick; I don't think it needs to hold up
pushing this.
http://codereview.appspot.com/4811066/diff/8003/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
Again - not too familiar with the codereview tool, so I hope this makes
sense. New patch set soon.
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
- Original Message -
From: philehol...@googlemail.com
To: percival.music...@gmail.com; n.putt...@gmail.com
Cc: re...@codereview.appspotmail.com; lilypond-devel@gnu.org
Sent: Saturday, August 06, 2011 3:57 PM
Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)
Again - not too
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode25
input/regression/mozart-hrn-3.ly:25: \fill-line { This music is part of
the
- Original Message -
From: n.putt...@gmail.com
To: philehol...@googlemail.com; percival.music...@gmail.com;
m...@philholmes.net
Cc: lilypond-devel@gnu.org; re...@codereview.appspotmail.com
Sent: Saturday, August 06, 2011 4:23 PM
Subject: Re: Rewrite regtest mozart-hrn-3.ly (issue4811066
Reviewers: Graham Percival,
Message:
Please review.
Description:
This regtest had a number of old lines of syntax and produces warnings
with the latest version of LilyPond. It also uses tabs for indents.
This is a cleaner, warning-free version.
Please review this at
LGTM, although I initially misread the commit message as saying that the
*new* version uses tabs for indents. Maybe change that to the old
version used tabs, just for extra clarity ?
http://codereview.appspot.com/4811066/
___
lilypond-devel mailing
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
http://codereview.appspot.com/4811066/diff/1/input/regression/mozart-hrn-3.ly#newcode25
input/regression/mozart-hrn-3.ly:25: \fill-line { This music is part of
the
20 matches
Mail list logo
