Re: Running fixcc.py

2020-03-23 Thread Dan Eble
On Mar 23, 2020, at 18:41, David Kastrup wrote: > > Dan Eble writes: > >> I'll submit that for review along with some tweaks to the clang-format >> configuration. I still have some testing to do. > > Thanks, and sorry for causing that workload out of not really thinking > through things. Thi

Re: Running fixcc.py

2020-03-23 Thread David Kastrup
Dan Eble writes: > On Mar 23, 2020, at 17:10, David Kastrup wrote: >> >> Dan Eble writes: > >>> As far as I'm concerned, we could just declare 3.1 to be the new >>> preferred version. I'm not sure whether that would inconvenience >>> anyone else, though. >> >> It's the current version, so ev

Re: Running fixcc.py

2020-03-23 Thread Dan Eble
On Mar 23, 2020, at 17:10, David Kastrup wrote: > > Dan Eble writes: >> As far as I'm concerned, we could just declare 3.1 to be the new >> preferred version. I'm not sure whether that would inconvenience >> anyone else, though. > > It's the current version, so eventually it might have become

Re: Running fixcc.py

2020-03-23 Thread David Kastrup
Dan Eble writes: > On Mar 22, 2020, at 17:04, David Kastrup wrote: >> >> Dan Eble writes: >> >>> Did you use astyle 2.04 or another version? I built 2.04 from source > ... >> 3.1. I am afraid that I may have updated my system since the review, > ... >> So where should we go from here? > > A

Re: Running fixcc.py

2020-03-22 Thread Dan Eble
On Mar 22, 2020, at 17:04, David Kastrup wrote: > > Dan Eble writes: > >> Did you use astyle 2.04 or another version? I built 2.04 from source ... > 3.1. I am afraid that I may have updated my system since the review, ... > So where should we go from here? As far as I'm concerned, we could j

Re: Running fixcc.py

2020-03-22 Thread David Kastrup
Dan Eble writes: > On Mar 21, 2020, at 11:26, David Kastrup wrote: >> it got a bit lost in other things, but I think I would want to run >> fixcc.py right now, reformatting the C++ stuff (it doesn't help with the >> conventions for template arguments but there are comparatively few of >> those).

Re: Running fixcc.py

2020-03-22 Thread Dan Eble
On Mar 21, 2020, at 11:26, David Kastrup wrote: > it got a bit lost in other things, but I think I would want to run > fixcc.py right now, reformatting the C++ stuff (it doesn't help with the > conventions for template arguments but there are comparatively few of > those). Did you use astyle 2.04

Re: Running fixcc.py

2020-03-21 Thread Dan Eble
On Mar 21, 2020, at 11:26, David Kastrup wrote: > it got a bit lost in other things, but I think I would want to run > fixcc.py right now, reformatting the C++ stuff (it doesn't help with the > conventions for template arguments but there are comparatively few of > those). OK here. Also, thanks

Re: Running fixcc.py

2020-03-21 Thread David Kastrup
Torsten Hämmerle writes: > Hi David, > > No objections! > Probably this is, directly after introduction of new stable, the best > opportunity for tidying up and general re-formatting we'll have in years. > > I'm a bit confused though: starting off with fixcc, you are suddenly > talking about fix

Re: Running fixcc.py

2020-03-21 Thread Torsten Hämmerle
Hi David, No objections! Probably this is, directly after introduction of new stable, the best opportunity for tidying up and general re-formatting we'll have in years. I'm a bit confused though: starting off with fixcc, you are suddenly talking about fixscm. Is it about cc files, or scm files,

Running fixcc.py

2020-03-21 Thread David Kastrup
Hi, it got a bit lost in other things, but I think I would want to run fixcc.py right now, reformatting the C++ stuff (it doesn't help with the conventions for template arguments but there are comparatively few of those). It's been run on stable already; so running on master makes future cherry