Oh one thing to add, I am seeing a lot of this in the reg test:
--snip--
input/regression/midi/staff-map-instrument.midi
@@ -1,4 +1,4 @@
-track 0 ev (0, (255, 3, 'control track'))
+track 0 ev (0, (255, 3, ''))
ev (0, (255, 1, 'creator: '))
ev (0, (255, 88,
https://codereview.appspot.com/256230045/diff/1/lily/performance.cc
File lily/performance.cc (right):
https://codereview.appspot.com/256230045/diff/1/lily/performance.cc#newcode41
lily/performance.cc:41: header_ (SCM_EOL)
On 2015/08/06 11:22:27, dak wrote:
On 2015/08/06 11:05:56, ht wrote:
I
https://codereview.appspot.com/256230045/diff/1/lily/performance.cc
File lily/performance.cc (right):
https://codereview.appspot.com/256230045/diff/1/lily/performance.cc#newcode41
lily/performance.cc:41: header_ (SCM_EOL)
On 2015/08/06 11:05:56, ht wrote:
On 2015/08/06 02:30:37, Dan Eble
https://codereview.appspot.com/256230045/diff/1/lily/include/performance.hh
File lily/include/performance.hh (right):
https://codereview.appspot.com/256230045/diff/1/lily/include/performance.hh#newcode44
lily/include/performance.hh:44: void write_output (string filename,
const string name)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello Heikki
On 04/08/15 23:35, ht.lilypond.developm...@gmail.com wrote:
Reviewers: ,
Message: This patch adds support for setting the MIDI sequence
name for MIDI output files using the value of the midititle field
from a relevant \header
On 2015/08/05 08:05:44, ht wrote:
On 2015/08/05 07:50:08, http://pkx_gnu.org wrote:
Does this patch have a google tracker? I couldn't find one. If not
can
you create one (with the summary and the link to this Rietveld) so
that I can keep track of its progress while it is tested and
Fails make
https://codereview.appspot.com/256230045/diff/1/lily/performance-scheme.cc
File lily/performance-scheme.cc (right):
https://codereview.appspot.com/256230045/diff/1/lily/performance-scheme.cc#newcode46
lily/performance-scheme.cc:46: Write @var{performance} to
@var{filename} with name
https://codereview.appspot.com/256230045/diff/1/lily/include/performance.hh
File lily/include/performance.hh (right):
https://codereview.appspot.com/256230045/diff/1/lily/include/performance.hh#newcode44
lily/include/performance.hh:44: void write_output (string filename,
const string name)
I don't have enough knowledge for a LGTM, but reading the source code I
noticed one detail...
https://codereview.appspot.com/256230045/diff/1/lily/performance.cc
File lily/performance.cc (right):
https://codereview.appspot.com/256230045/diff/1/lily/performance.cc#newcode92
Reviewers: ,
Message:
This patch adds support for setting the MIDI sequence name for MIDI
output files using the value of the midititle field from a relevant
\header block, and falling back to using the title field if
midititle
has not been defined. (This should be analogous to how pdftitle and
10 matches
Mail list logo