Re: Sketch for DotColumn not triggering vertical alignment. (issue 5538049)

2012-01-15 Thread mtsolo
Reviewers: lemzwerg, carl.d.sorensen_gmail.com, Keith, http://codereview.appspot.com/5538049/diff/1/lily/staff-symbol-referencer.cc File lily/staff-symbol-referencer.cc (right): http://codereview.appspot.com/5538049/diff/1/lily/staff-symbol-referencer.cc#newcode95 lily/staff-symbol-referencer.c

Re: Sketch for DotColumn not triggering vertical alignment. (issue 5538049)

2012-01-15 Thread k-ohara5a5a
LGTM. Now I see why this bug appeared. The recent changes to the beam configuration code need to know the note-spacing, which depends on the horizontal dot positions. So, dot configuration may not wait for beaming. The code configuring dots was (indirectly and wrongly) causing rest-collision to

Re: Sketch for DotColumn not triggering vertical alignment. (issue 5538049)

2012-01-12 Thread Carl . D . Sorensen
A few comments. Thanks, Carl http://codereview.appspot.com/5538049/diff/1/input/regression/dot-column-vertical-positioning.ly File input/regression/dot-column-vertical-positioning.ly (right): http://codereview.appspot.com/5538049/diff/1/input/regression/dot-column-vertical-positioning.ly#new

Sketch for DotColumn not triggering vertical alignment. (issue 5538049)

2012-01-12 Thread lemzwerg
LGTM, but not time to test... http://codereview.appspot.com/5538049/diff/1/lily/staff-symbol-referencer.cc File lily/staff-symbol-referencer.cc (right): http://codereview.appspot.com/5538049/diff/1/lily/staff-symbol-referencer.cc#newcode95 lily/staff-symbol-referencer.cc:95: Real y = (pure The