https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly
File ly/arabic.ly (right):
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly#newcode42
ly/arabic.ly:42: % Ajam family
On 2017/04/25 20:32:19, thomasmorley651 wrote:
There seems to be no entry for 'Ajam family'. Or
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly
File ly/arabic.ly (right):
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly#newcode19
ly/arabic.ly:19: \version "2.18.2"
On 2017/04/25 20:39:10, dak wrote:
On 2017/04/25 20:32:19, thomasmorley651 wrote:
> The
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly
File ly/arabic.ly (right):
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly#newcode19
ly/arabic.ly:19: \version "2.18.2"
On 2017/04/25 20:32:19, thomasmorley651 wrote:
The version should be the version since this
Hi Amir,
thanks a lot for your patch.
I don't know anything about arabic music.
So most comments are naggings about formating/indenting issues...
Thanks,
Harm
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly
File ly/arabic.ly (right):
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly
File ly/arabic.ly (right):
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode88
ly/arabic.ly:88:
On 2017/04/25 10:51:47, amir130 wrote:
On 2017/04/24 18:09:59, dak wrote:
> Whitespace error?
>
> Maybe check with
>
>
Reviewers: dak,
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly
File ly/arabic.ly (right):
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode88
ly/arabic.ly:88:
On 2017/04/24 18:09:59, dak wrote:
Whitespace error?
Maybe check with
git log --check
or so?
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly
File ly/arabic.ly (right):
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode28
ly/arabic.ly:28:
Whitespace error?
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode86
ly/arabic.ly:86:
Whitespace