Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-19 Thread hanwenn
LGTM https://codereview.appspot.com/557410043/

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-13 Thread dak
On 2020/02/13 13:37:52, hanwenn wrote: > looks OK. > > Is there a way to exercise this? Maybe with #{ c4'' #} or something? Just { c4'' } would do it, but regtesting error messages is pretty icky. Warnings are more straightforward, but I really want an error. https://codereview.appspot.com/5574

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-13 Thread hanwenn
looks OK. Is there a way to exercise this? Maybe with #{ c4'' #} or something? https://codereview.appspot.com/557410043/

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-12 Thread dak
https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy#newcode3676 lily/parser.yy:3676: | pitch exclamations questions octave_check duration stray_quotes optional_rest post_events

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-11 Thread hanwenn
https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy#newcode3676 lily/parser.yy:3676: | pitch exclamations questions octave_check duration stray_quotes optional_rest post_events

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-11 Thread dak
Reviewers: lemzwerg, Carl, Message: On 2020/02/11 22:37:39, Carl wrote: > On 2020/02/11 21:46:52, lemzwerg wrote: > > Good idea! From inspection only, LGTM. > > Sounds like a great idea! > > Carl Well, I sort of got a feature request.

Re: Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-11 Thread Carl . D . Sorensen
On 2020/02/11 21:46:52, lemzwerg wrote: > Good idea! From inspection only, LGTM. Sounds like a great idea! Carl https://codereview.appspot.com/557410043/

Special-case syntax error of duration before octave marks (issue 557410043 by d...@gnu.org)

2020-02-11 Thread lemzwerg--- via Discussions on LilyPond development
Good idea! From inspection only, LGTM. https://codereview.appspot.com/557410043/