On 2011/07/30 22:59:11, Reinhold wrote:
I think that you forgot to rebase your branch to origin/master before
uploading
that patch. Your version does not have some of the latest patches in
the git
tree, so it appears that you are reverting some of those patches.
Reviewers: dak,
Message:
This patch removes all deprecation warnings about Guile format needing
two parameters.
This is the original patch as pushed by David, plus changes in
ly/init.ly, ly/titling-init.ly and ly/graphviz_init.ly to use ly:format
instead of format in embedded scheme statements.
If I understand correctly, ly:format might be useful for printing
Lilypond's own data structures.
Anyway, I discovered after already having applied my patch that Lilypond
was intended to replace the system format with its own version.
So the question is whether we should try to find out why
http://codereview.appspot.com/4808063/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (left):
http://codereview.appspot.com/4808063/diff/1/scm/define-markup-commands.scm#oldcode1490
scm/define-markup-commands.scm:1490: (stacked-extent (ly:stencil-extent
stacked-stencil
I think that you forgot to rebase your branch to origin/master before
uploading that patch. Your version does not have some of the latest
patches in the git tree, so it appears that you are reverting some of
those patches.
