Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-11 Thread mtsolo
Pushed as e75f38b1a9adaf7752ced683fff0e6ec01bd8a13. Cheers, MS http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-10 Thread n . puttock
LGTM. http://codereview.appspot.com/4822046/diff/4001/input/regression/multi-measure-rest-staff-position.ly File input/regression/multi-measure-rest-staff-position.ly (right): http://codereview.appspot.com/4822046/diff/4001/input/regression/multi-measure-rest-staff-position.ly#newcode1

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-10 Thread reinhold . kainhofer
LGTM. I wonder why we use get_positino in the first place, which uses the staff-position property only as a fall-back... http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-08 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-07 Thread tdanielsmusic
Not tested, but LGTM http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-07-27 Thread mtsolo
On 2011/07/23 20:54:40, MikeSol wrote: Should fix issue 1604. Passes regtests. http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-07-23 Thread mtsolo
Reviewers: , Message: Should fix issue 1604. Description: Treats multi measure rest staff position like rest staff position. Please review this at http://codereview.appspot.com/4822046/ Affected files: M lily/multi-measure-rest.cc M scm/define-grobs.scm Index: lily/multi-measure-rest.cc