Pushed as 829f0ded77ee44ea6f0566fb5e5318802a8857ad.
http://codereview.appspot.com/5030053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/09/21 21:11:50, Neil Puttock wrote:
remove extra parens
Done.
Janek and Pal: thanks!
http://codereview.appspot.com/5030053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/5030053/diff/2004/lily/mensural-ligature.cc
File lily/mensural-ligature.cc (right):
http://codereview.appspot.com/5030053/diff/2004/lily/mensural-ligature.cc#newcode74
lily/mensural-ligature.cc:74: = (me->layout ()->get_dimension
(ly_symbol2scm ("blot-diameter")));
On 2011/09/18 19:55:47, Bertrand Bordage wrote:
Another update that fixes some variable errors.
It now passes make.
thanks Bertrand, this is great work;
I can now print flexae just the default way!
(so long I had to use non-default viewers and lpr commands.)
p
http://codereview.appspot.com/50
2011/9/19 :
> On 2011/09/18 21:47:04, janek wrote:
>>
>> I think LGTM, but it would be great if you'd add a regtest to
>
> demonstrate what
>>
>> this patch is fixing.
>
> I don't think so. mensural-ligatures.ly contains every case fixed by
> this patch.
True. However, your changes are very subt
On 2011/09/18 21:47:04, janek wrote:
I think LGTM, but it would be great if you'd add a regtest to
demonstrate what
this patch is fixing.
I don't think so. mensural-ligatures.ly contains every case fixed by
this patch.
If I make a regtest to show such tiny graphical differences, then we
would
I think LGTM, but it would be great if you'd add a regtest to
demonstrate what this patch is fixing. (i was going to write
"before/after pdfs attached to tracker issue would be priceless!" but
i've just saw that you added them - perfect!)
thanks,
Janek
http://codereview.appspot.com/5030053/dif
Oh, yes. Thanks Werner, this is fixed.
http://codereview.appspot.com/5030053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
MF code LGTM.
http://codereview.appspot.com/5030053/diff/9001/mf/parmesan-noteheads.mf
File mf/parmesan-noteheads.mf (right):
http://codereview.appspot.com/5030053/diff/9001/mf/parmesan-noteheads.mf#newcode497
mf/parmesan-noteheads.mf:497: draw_mensural_longa (m_longa_width,
m_holeheight, true,
hi Bertrand,
Another update that fixes some variable errors.
It now passes make.
this is ok, passes apply, make and all my test; thanks!
p
http://codereview.appspot.com/5030053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.g
Another update that fixes some variable errors.
It now passes make.
http://codereview.appspot.com/5030053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Pal!
I updated the patch.
This wasn't working since Werner's e10a13.
It couldn't be applied to 0dcc93: I forgot some files that I added in
0e31cd.
Bertrand
http://codereview.appspot.com/5030053/
___
lilypond-devel mailing list
lilypond-devel@gnu.o
hi Bertrand,
> The new mensural style introduced with commit
> 0dcc93c0a5a97d048db2f7631966f41ae0059ab5 created some ugliness's in
> mensural ligatures.
which commit is the patch supposed to apply to?
I couldn't apply it to my HEAD
f8a4491c571dc57c87aec33dc8e34c436e222537;
having applied it to 0d
Passes make and reg tests - I get differences but they look ok
see:
http://code.google.com/p/lilypond/issues/detail?id=1898#c1
http://codereview.appspot.com/5030053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman
Reviewers: benko.pal,
Message:
Hi,
The new mensural style introduced with commit
0dcc93c0a5a97d048db2f7631966f41ae0059ab5 created some ugliness's in
mensural ligatures.
This patch fix these. I also added serifs to flexas.
Regards,
Bertrand
Description:
Unifies mensural ligatures with blot-dia
15 matches
Mail list logo
