Am Samstag, 22. August 2009 02:07:05 schrieb Reinhold Kainhofer:
> Am Samstag, 22. August 2009 00:59:33 schrieb joenee...@gmail.com:
> > http://codereview.appspot.com/109070/diff/1/2
> > File lily/general-scheme.cc (right):
> >
> > http://codereview.appspot.com/109070/diff/1/2#newcode437
> > Line 4
On Sat, 2009-08-22 at 13:01 +0200, Reinhold Kainhofer wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Am Samstag, 22. August 2009 02:28:39 schrieb joenee...@gmail.com:
> > On 2009/08/22 00:11:34, Reinhold wrote:
> > > http://codereview.appspot.com/109070/diff/1/2
> > > File lily/gener
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am Samstag, 22. August 2009 02:28:39 schrieb joenee...@gmail.com:
> On 2009/08/22 00:11:34, Reinhold wrote:
> > On 2009/08/21 22:59:33, joeneeman wrote:
> > > Don't forget to escape $. Or else use single quotes rather than double
> > > quotes.
>
> > Go
If we're covering shell variables for Windows, like $ for *ix, we'd need
to escape "%" character, too.
That way we'd handle cmd variables like %HOME% or %PATH%.
http://codereview.appspot.com/109070/diff/15/16
File lily/general-scheme.cc (right):
http://codereview.appspot.com/109070/diff/15/16#n
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am Samstag, 22. August 2009 02:28:39 schrieb joenee...@gmail.com:
> On 2009/08/22 00:11:34, Reinhold wrote:
> > http://codereview.appspot.com/109070/diff/1/2
> > File lily/general-scheme.cc (right):
> >
> > http://codereview.appspot.com/109070/diff/1/2
On 2009/08/22 00:11:34, Reinhold wrote:
http://codereview.appspot.com/109070/diff/1/2
File lily/general-scheme.cc (right):
http://codereview.appspot.com/109070/diff/1/2#newcode437
Line 437: replace_all (&s, "\"", "\\\"");
On 2009/08/21 22:59:33, joeneeman wrote:
> Don't forget to escape $. Or
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am Samstag, 22. August 2009 00:59:33 schrieb joenee...@gmail.com:
> http://codereview.appspot.com/109070/diff/1/2
> File lily/general-scheme.cc (right):
>
> http://codereview.appspot.com/109070/diff/1/2#newcode437
> Line 437: replace_all (&s, "\"", "\\
http://codereview.appspot.com/109070/diff/1/2
File lily/general-scheme.cc (right):
http://codereview.appspot.com/109070/diff/1/2#newcode432
Line 432: else if (scm_is_string (arg)) {
Can you also fix the indentation (move open brace to next line) and
below likewise?
http://codereview.appspot.com
http://codereview.appspot.com/109070/diff/1/2
File lily/general-scheme.cc (right):
http://codereview.appspot.com/109070/diff/1/2#newcode437
Line 437: replace_all (&s, "\"", "\\\"");
Don't forget to escape $. Or else use single quotes rather than double
quotes.
http://codereview.appspot.com/1090
