Patch counted down - please push
https://codereview.appspot.com/236480043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch on countdown for June 17th
https://codereview.appspot.com/236480043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Please review. Per feedback I narrowed and tested the convert-ly rule
and edited the changes entry. (I also redid the commits for better
commit history.)
-Paul
https://codereview.appspot.com/236480043/
___
lilypond-devel mailing list
lilypond-devel@g
> On Jun 9, 2015, at 8:30 AM, David Kastrup wrote:
>
> Always do that in a separate commit with only the changes from running
> makelsr, like with
>
> git commit -m "Run scripts/auxiliar/makelsr.py" -a
>
> In general, always keep automated changes and manual changes in separate
> commits in ord
James Lowe writes:
> On 08/06/15 19:23, Paul Morris wrote:
>> Ok. Sounds like the CG would benefit from some updating on this
>> point, as it currently simply says to run makelsr (in 10.9.5)
>> before submitting for review (in 10.9.9).
>
> Yes it could be improved.
>
>>
>> Sounds like you are s
On 08/06/15 19:23, Paul Morris wrote:
> Ok. Sounds like the CG would benefit from some updating on this
> point, as it currently simply says to run makelsr (in 10.9.5)
> before submitting for review (in 10.9.9).
Yes it could be improved.
>
> Sounds like you are saying there’s a way to run makel
Paul Morris writes:
> On Jun 8, 2015, at 2:07 AM, pkx1...@gmail.com wrote:
>
>> Yes, do not edit the snippet directly in ../snippets/.. or add it
>> directly to the snippets/.. directory.
>
> I see, thanks, but what to do if running “update-with-convert-ly.sh”
> changes snippets in the /snippets/
> On Jun 8, 2015, at 2:07 AM, pkx1...@gmail.com wrote:
>
> On 2015/06/07 20:43:54, Keith wrote:
>> lgtm, if you can narrow the convert-ly rule a bit and test it (the
>> semi-automated 'patchy' testing doesn't use convert-ly)
>
>> Also, I think you need to add
>
>> Documentation/snippets/new/blan
https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely#newcode66
Documentation/changes.tely:66: now create a white background that
follows the outline o
On 2015/06/07 20:43:54, Keith wrote:
lgtm, if you can narrow the convert-ly rule a bit and test it (the
semi-automated 'patchy' testing doesn't use convert-ly)
Also, I think you need to add
Documentation/snippets/new/blanking-staff-lines-using-the--whiteout-command.ly
and let the makelsr sc
lgtm, if you can narrow the convert-ly rule a bit and test it (the
semi-automated 'patchy' testing doesn't use convert-ly)
Also, I think you need to add
Documentation/snippets/new/blanking-staff-lines-using-the--whiteout-command.ly
and let the makelsr script update the copy in /snippets/, but I'm
> On Jun 2, 2015, at 2:58 AM, David Kastrup wrote:
>>
>> Looking at the first few lines of update-with-convert-ly, it looks
>> like it expects you to have defined the build directory as BUILD_DIR
>> where most other scripts expect LILYPOND_BUILD_DIR.
>
> Probably an oversight and worth fixing.
Just uploaded patch set 4.
It includes improved convert-ly rules. I ran
scripts/auxiliar/update-with-convert-ly.sh
with these rules on both a clean branch and on the branch where I'm
working on this functionality. It worked as expected for both.
This patch set also includes a changes entry and
David Kastrup writes:
> "Keith OHara" writes:
>
>> On Mon, 01 Jun 2015 19:29:41 -0700, wrote:
>>
>>> scripts/auxiliar/update-with-convert-ly.sh
>>> I get this:
>>>
>>> make: *** No rule to make target `python-modules'. Stop.
>>> xargs: ./out/bin/convert-ly: No such file or directory
>>> xargs:
"Keith OHara" writes:
> On Mon, 01 Jun 2015 19:29:41 -0700, wrote:
>
>> scripts/auxiliar/update-with-convert-ly.sh
>> I get this:
>>
>> make: *** No rule to make target `python-modules'. Stop.
>> xargs: ./out/bin/convert-ly: No such file or directory
>> xargs: ./out/bin/convert-ly: No such file
On Mon, 01 Jun 2015 19:29:41 -0700, wrote:
scripts/auxiliar/update-with-convert-ly.sh
I get this:
make: *** No rule to make target `python-modules'. Stop.
xargs: ./out/bin/convert-ly: No such file or directory
xargs: ./out/bin/convert-ly: No such file or directory
I'm running LilyDev3 in a v
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py#newcode3751
python/convertrules.py:3751: str = re.sub (r'\bwhiteout\b',
'whiteout-box', str)
On 2015/06/02 01
I updated convertrules.py as follows:
@rule ((2, 19, 22), """whiteout -> whiteout-box""")
def conv(str):
str = re.sub (r"\whiteout", r"\whiteout-box", str)
str = re.sub (r".whiteout", r".whiteout-box", str)
str = re.sub (r"#'whiteout", r"#'whiteout-box", str)
str = re.sub (r"stenc
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py#newcode3751
python/convertrules.py:3751: str = re.sub (r'\bwhiteout\b',
'whiteout-box', str)
On 2015/06/01 23
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/236480043/diff/40001/python/convertrules.py#newcode3751
python/convertrules.py:3751: str = re.sub (r'\bwhiteout\b',
'whiteout-box', str)
That seems like
New patch set uploaded for review (3rd one):
https://codereview.appspot.com/236480043
Please review, especially the convert-ly rule, grob.cc, and doc strings.
Includes commits:
convert-ly: add whiteout -> whiteout-box
rhythms.itely: improve text for whiteout-box
let \whiteout use
LGTM.
~ Simon
Am 01.06.2015 um 17:50 schrieb paulwmor...@gmail.com:
But I think I prefer the following which has a consistent parallel
structure across all the categories and where the new style of whiteout
is named in a way that conveys that it is the default, with the old box
style getting a m
https://codereview.appspot.com/236480043/diff/20001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/236480043/diff/20001/Documentation/notation/rhythms.itely#newcode555
Documentation/notation/rhythms.itely:555: collide with o
On 2015/05/31 01:07:47, Keith wrote:
I realize I am changing my opinion here on a few points:
1) leave the old whiteout as a simple box and give the new function a
new name
2) enabling either type of whiteout through a single property looks
better
3) the thickness should be in terms of line-t
On Sun, 31 May 2015 05:03:05 -0700, Simon Albrecht
wrote:
(A convert-ly rule may be needed… maybe in any case to
change whiteout to whiteout-box? ...or maybe not?)
Looking at the existing uses of \whiteout Xxx.whiteout, it does seem
best to leave the plain box whiteout in existing scores. Co
Hello,
Am 31.05.2015 um 03:07 schrieb k-ohara5...@oco.net:
I realize I am changing my opinion here on a few points:
[…]
(A convert-ly rule may be needed… maybe in any case to
change whiteout to whiteout-box? ...or maybe not?)
Looking at the existing uses of \whiteout Xxx.whiteout, it does
I realize I am changing my opinion here on a few points:
1) leave the old whiteout as a simple box and give the new function a
new name
2) enabling either type of whiteout through a single property looks
better
3) the thickness should be in terms of line-thickness rather than
staff-space
I hope y
Passes make, make check - reg test diff attached to the tracker (issue
4418)
I'll run a full make doc, so assume no update means it has passed
https://codereview.appspot.com/236480043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lis
> On May 28, 2015, at 8:21 AM, pkx1...@gmail.com wrote:
>
> Paul, I've set the Google Tracker (#4418) to 'needs_work' based on the
> comments here
Thanks James. I’ve uploaded a second patch set for review.
https://codereview.appspot.com/236480043/
(git-cl gave me “Incorrect username or passwo
Paul, I've set the Google Tracker (#4418) to 'needs_work' based on the
comments here
https://codereview.appspot.com/236480043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2015/05/25 13:06:26, Valentin Villenave wrote:
I’ve always been unhappy with the current method for whiteout (which I
have also
been using in rounded-box-stencil, nevertheless). LilyPond scores’
background is
_not_ white, but alpha transparent. Look for example at the way
Frescobaldi
dis
On 2015/05/25 22:24:01, Keith wrote:
The additional copies of the stencils do make the PDF files noticeably
larger.
8% larger when I used 16-copy whiteout around all dynamics and text
marks in a
string quartet score.
The compilation time increased by 2%, desipte the repeated
computations
Thanks for the reviews.
On 2015/05/24 22:56:44, Keith wrote:
I think whiteout-stencil should simply call this function, with the
defaults
suggested, so that the existing
\set Xx.whiteout=##t and \markup\whiteout use this new method.
We could provide access to the old whiteout method with
\s
The additional copies of the stencils do make the PDF files noticeably
larger. 8% larger when I used 16-copy whiteout around all dynamics and
text marks in a string quartet score.
The compilation time increased by 2%, desipte the repeated computations
of sines and cosines.
With \pointAndClickOn
On 2015/05/25 20:43:30, Carl wrote:
In my opinion, whiteout needs to create a layer of white paint.
That's what
whiteout means.
Well, "whiteout" is the name chosen by a couple modern Dutch
programmers, but we don't really want whiteout.
We want that thing that happens when you fill the neigh
I like what you've done.
I like Keith's suggestion for delayed stencil evaluation.
Thanks,
Carl
https://codereview.appspot.com/236480043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2015/05/25 13:06:26, Valentin Villenave wrote:
So, ideally \whiteout should mimic this behavior rather than cover
stuff with a
layer of white paint. Not sure how to do that, though.
In my opinion, whiteout needs to create a layer of white paint. That's
what whiteout means. It's like us
On 2015/05/24 22:56:44, Keith wrote:
I think whiteout-stencil should simply call this function, with the
defaults
suggested, so that the existing
\set Xx.whiteout=##t and \markup\whiteout use this new method.
I’ve always been unhappy with the current method for whiteout (which I
have also bee
We certainly want this in LilyPond, and for it to be easy to use.
I think whiteout-stencil should simply call this function, with the
defaults suggested, so that the existing
\set Xx.whiteout=##t and \markup\whiteout use this new method.
We could provide access to the old whiteout method with
\s
Reviewers: ,
Message:
Please review, thanks.
See discussion here for background and usage demo:
http://lists.gnu.org/archive/html/lilypond-user/2015-05/msg00522.html
I have not yet done a regtest, but will add one if this is reviewed
favorably for inclusion in LilyPond.
Description:
add stenci
40 matches
Mail list logo
