Re: automated formatting

2020-01-30 Thread Werner LEMBERG
> * statically linked binaries of clang-format are available here: > https://github.com/angular/clang-format/tree/master/bin ; Aaah! This is very nice, thanks. > 1. Recognize clang-format as a "good enough", so I can use it > locally on my diffs and not get reviews on style. I did a quick vie

Re: automated formatting

2020-01-30 Thread Han-Wen Nienhuys
On Tue, Jan 28, 2020 at 8:08 PM David Kastrup wrote: > >>Can you provide me with a presubmit hook that applies fixcc? Can you > >>guarantee that, if fixcc has run on the code, there will be no further > >>remarks on code formatting during review? > >> > >> I think that it's a really go

Re: automated formatting

2020-01-28 Thread David Kastrup
Dan Eble writes: > On Jan 28, 2020, at 12:11, Carl Sorensen wrote: >>Can you provide me with a presubmit hook that applies fixcc? Can you >>guarantee that, if fixcc has run on the code, there will be no further >>remarks on code formatting during review? >> >> I think that it's a re

Re: automated formatting

2020-01-28 Thread Dan Eble
On Jan 28, 2020, at 12:11, Carl Sorensen wrote: >Can you provide me with a presubmit hook that applies fixcc? Can you >guarantee that, if fixcc has run on the code, there will be no further >remarks on code formatting during review? > > I think that it's a really good idea to have pre

Re: automated formatting

2020-01-28 Thread Carl Sorensen
7, 2020 at 11:49 AM David Kastrup wrote: > >>> > I want to propose to move to automated formatting for our C++ code. > >>> > > >>> > I put up a .clang-format code that mostly mimicks our style at > >>> > > >>> > ht

Re: automated formatting

2020-01-28 Thread Han-Wen Nienhuys
On Tue, Jan 28, 2020 at 12:18 AM David Kastrup wrote: > > David Kastrup writes: > > > Han-Wen Nienhuys writes: > > > >> On Mon, Jan 27, 2020 at 11:49 AM David Kastrup wrote: > >>> > I want to propose to move to automated formatting for our C++ c

Re: automated formatting

2020-01-27 Thread David Kastrup
David Kastrup writes: > Han-Wen Nienhuys writes: > >> On Mon, Jan 27, 2020 at 11:49 AM David Kastrup wrote: >>> > I want to propose to move to automated formatting for our C++ code. >>> > >>> > I put up a .clang-format code that

Re: automated formatting

2020-01-27 Thread David Kastrup
Han-Wen Nienhuys writes: > On Mon, Jan 27, 2020 at 11:49 AM David Kastrup wrote: >> > I want to propose to move to automated formatting for our C++ code. >> > >> > I put up a .clang-format code that mostly mimicks our style at >> > >> > http

Re: automated formatting

2020-01-27 Thread Han-Wen Nienhuys
On Mon, Jan 27, 2020 at 11:49 AM David Kastrup wrote: > > I want to propose to move to automated formatting for our C++ code. > > > > I put up a .clang-format code that mostly mimicks our style at > > > > https://codereview.appspot.com/561340043 > > >

Re: automated formatting

2020-01-27 Thread Dan Eble
On Jan 27, 2020, at 07:43, David Kastrup wrote: > > Frankly, I just forgot about either. I think it would be a good idea to > take up this practice again. Regarding Clang: unless Astyle falls apart > using C++11 constructs that are going to occur more frequently in > future, I think there is li

Re: automated formatting

2020-01-27 Thread David Kastrup
David Kastrup writes: > Han-Wen Nienhuys writes: > >> I want to propose to move to automated formatting for our C++ code. >> >> I put up a .clang-format code that mostly mimicks our style at >> >> https://codereview.appspot.com/561340043 >> >>

Re: automated formatting

2020-01-27 Thread David Kastrup
Han-Wen Nienhuys writes: > I want to propose to move to automated formatting for our C++ code. > > I put up a .clang-format code that mostly mimicks our style at > > https://codereview.appspot.com/561340043 > > I have a lot of good experience with automating code form

Re: automated formatting

2020-01-27 Thread Werner LEMBERG
> I put up a .clang-format code that mostly mimicks our style at > > https://codereview.appspot.com/561340043 > > I have a lot of good experience with automating code formatting. It > removes drudgery for code authors, obviates discussions over style > in code review, and generally elevates

automated formatting

2020-01-27 Thread Han-Wen Nienhuys
I want to propose to move to automated formatting for our C++ code. I put up a .clang-format code that mostly mimicks our style at https://codereview.appspot.com/561340043 I have a lot of good experience with automating code formatting.. It removes drudgery for code authors, obviates